lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Muir (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (LUCENE-4489) improve LimitTokenCountFilter and/or it's tests
Date Thu, 18 Oct 2012 05:00:03 GMT

     [ https://issues.apache.org/jira/browse/LUCENE-4489?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Robert Muir updated LUCENE-4489:
--------------------------------

    Attachment: LUCENE-4489.patch

same patch as the above, just passing null in the test for finalOffset when consumeAll is
false.

This way the test isn't fragile, we know that if you specify false for consumeAll that its
likely wrong and will screw up highlighting for multivalued fields, etc (since it doesnt consume
the whole stream, it doesnt necessarily know the real "end").
                
> improve LimitTokenCountFilter and/or it's tests
> -----------------------------------------------
>
>                 Key: LUCENE-4489
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4489
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Hoss Man
>         Attachments: LUCENE-4489.patch, LUCENE-4489.patch, LUCENE-4489.patch
>
>
> spinning off a discussion about LimitTokenCountFilter  and it's tests from SOLR-3961
(which was about a specific bug in the LimitTokenCountFilterFactory)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message