lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Simon Willnauer (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-4472) Add setting that prevents merging on updateDocument
Date Tue, 16 Oct 2012 11:37:04 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-4472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13476928#comment-13476928
] 

Simon Willnauer commented on LUCENE-4472:
-----------------------------------------

bq. The other two methods (findForceMerges, findForcedDeletesMerges) are only triggered when
the app explicitly asked IndexWriter to do so.

I am not sure if we should really do that. I'd rather make those two methods protected and
make it a impl detail of merge policy. I think the specialized methods are a poor man's approach
to the MergeContext and the api is rather clumsy along those lines. I'd be happy to not break
bw. compat but only add a more flexible API that is the authoritative source / single entry
point for the IndexWriter. If you think this through finfForcedDeletesMerges and findForcedMerges
are really and impl detail of the current IndexWriter and if we would modularize it would
become even more obvious.  
                
> Add setting that prevents merging on updateDocument
> ---------------------------------------------------
>
>                 Key: LUCENE-4472
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4472
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: core/index
>    Affects Versions: 4.0
>            Reporter: Simon Willnauer
>             Fix For: 4.1, 5.0
>
>         Attachments: LUCENE-4472.patch, LUCENE-4472.patch
>
>
> Currently we always call maybeMerge if a segment was flushed after updateDocument. Some
apps and in particular ElasticSearch uses some hacky workarounds to disable that ie for merge
throttling. It should be easier to enable this kind of behavior. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message