lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael McCandless (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-4472) Add setting that prevents merging on updateDocument
Date Tue, 16 Oct 2012 11:15:03 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-4472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13476915#comment-13476915
] 

Michael McCandless commented on LUCENE-4472:
--------------------------------------------

I like the new MergeCause enum!

But, instead of folding all parameters into a MergeContext, and exposing a single MergePolicy.findMerges
methods, can we keep the methods we have today and just add MergeCause as another parameter?
 This is a very expert API and I think it's fine to simply change it.  I think this approach
is more type-safe for the future, ie if we need to add something important such that a custom
merge policy should pay attention to it ... apps will see compilation errors on upgrading
and know they have to handle the new parameter.
                
> Add setting that prevents merging on updateDocument
> ---------------------------------------------------
>
>                 Key: LUCENE-4472
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4472
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: core/index
>    Affects Versions: 4.0
>            Reporter: Simon Willnauer
>             Fix For: 4.1, 5.0
>
>         Attachments: LUCENE-4472.patch, LUCENE-4472.patch
>
>
> Currently we always call maybeMerge if a segment was flushed after updateDocument. Some
apps and in particular ElasticSearch uses some hacky workarounds to disable that ie for merge
throttling. It should be easier to enable this kind of behavior. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message