lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Muir (JIRA)" <>
Subject [jira] [Commented] (SOLR-3961) LimitTokenCountFilterFactory config parsing is totally broken
Date Wed, 17 Oct 2012 20:06:03 GMT


Robert Muir commented on SOLR-3961:

For testing LimitTokenCountFilter, you need to set

Thats because LimitTokenCountFilter violates the workflow of the standard tokenstream API
it cuts off its consumer and calls end() even while that consumer still has more tokens: this
could easily cause unexpected side effects and bugs.

But we knew about this anyway: existing tests for LimitTokenCountFilter already do setEnableChecks(false)
for this exact reason... this is just an explanation of why.
> LimitTokenCountFilterFactory config parsing is totally broken
> -------------------------------------------------------------
>                 Key: SOLR-3961
>                 URL:
>             Project: Solr
>          Issue Type: Bug
>    Affects Versions: 4.0
>            Reporter: Hoss Man
>            Assignee: Hoss Man
>             Fix For: 4.0.1, 4.1
>         Attachments: SOLR-3961.patch
> As noted on the mailing list, LimitTokenCountFilterFactory throws a NumberFormatException
because it tries to use the value of it's config param as a key to look up another param that
it parses as an integer ... totally ridiculous.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see:

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message