Mailing-List: contact dev-help@lucene.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@lucene.apache.org
Received-SPF: pass (athena.apache.org: domain of rcmuir@gmail.com designates
 209.85.220.176 as permitted sender)
MIME-Version: 1.0
In-Reply-To: 
 <CAOdYfZWnV8FPhp=T5_sMYMWio70HDFQVOb7NAm9TDu--8kU9mw@mail.gmail.com>
References: 
 <CAOdYfZWnV8FPhp=T5_sMYMWio70HDFQVOb7NAm9TDu--8kU9mw@mail.gmail.com>
From: Robert Muir <rcmuir@gmail.com>
Date: Mon, 10 Sep 2012 10:36:02 -0400
Message-ID: 
 <CAOdYfZXD6R=ud1OgeZ+Y2BPSFfCG7ntLy2h76+r6OCFhEWdxuQ@mail.gmail.com>
Subject: Re: Purpose of CachingCollector.create(boolean, boolean, double) ?
To: dev@lucene.apache.org
Content-Type: text/plain; charset=UTF-8

fwiw, this method is only used by tests. I think we could safely
remove it and just have those tests (TestCachingCollector and one
grouping test) provide whatever collector they need instead.

On Mon, Sep 10, 2012 at 10:33 AM, Robert Muir <rcmuir@gmail.com> wrote:
> I'm looking at this code and a little confused:
>
> this wraps a no-op collector, so what happens if the maxRAMMB is
> exceeded? It seems to me in that case those hits would just be
> silently dropped?!
>
> Is this intentional?


-- 
lucidworks.com

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org