Return-Path: X-Original-To: apmail-lucene-dev-archive@www.apache.org Delivered-To: apmail-lucene-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 8414FD024 for ; Mon, 10 Sep 2012 18:12:27 +0000 (UTC) Received: (qmail 8310 invoked by uid 500); 10 Sep 2012 18:12:26 -0000 Delivered-To: apmail-lucene-dev-archive@lucene.apache.org Received: (qmail 8259 invoked by uid 500); 10 Sep 2012 18:12:26 -0000 Mailing-List: contact dev-help@lucene.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@lucene.apache.org Delivered-To: mailing list dev@lucene.apache.org Received: (qmail 8251 invoked by uid 99); 10 Sep 2012 18:12:26 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 10 Sep 2012 18:12:26 +0000 X-ASF-Spam-Status: No, hits=-0.7 required=5.0 tests=RCVD_IN_DNSWL_LOW,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of rcmuir@gmail.com designates 209.85.223.176 as permitted sender) Received: from [209.85.223.176] (HELO mail-ie0-f176.google.com) (209.85.223.176) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 10 Sep 2012 18:12:21 +0000 Received: by iecs9 with SMTP id s9so4409126iec.35 for ; Mon, 10 Sep 2012 11:12:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :content-type; bh=EmMEOguWvKuXShpy5zxVsYE2yA7XMxb1WEaHLMrblK0=; b=o/6cY5Ph8Kfs+nj038mMsILA88LPabQzOS05hDdZADnE/z7k080LsRLkTkNxXb35pT 2b9vK3ncBdq38KhJVdWZdBVgvqud0mgXz6KMuZ+t9E1jMCaE15wCmC3c+5E9+wiIaksy 6QgY14w1kvmwagPZquc30uQsKW/auX8j3Ey8gXVHi6UJqGV42tE1E+CLjnRfvmbiURTr IofNzSKNo0OIsBG0KuRNRCXgG+tricKQsnNNPMJwWMINe0usuMkJe1stzuHDmuFEUn3x /Id6IaFK07MHJ3EXxiasRDJSmvXOHFYXa0I6lpYgLuzx1+ek9aAi1uDeM2PwZ/APbbrv EFQg== Received: by 10.50.47.129 with SMTP id d1mr12008116ign.45.1347300721004; Mon, 10 Sep 2012 11:12:01 -0700 (PDT) MIME-Version: 1.0 Received: by 10.50.47.129 with HTTP; Mon, 10 Sep 2012 11:11:40 -0700 (PDT) In-Reply-To: References: <20120910180513.B0B52238896F@eris.apache.org> From: Robert Muir Date: Mon, 10 Sep 2012 14:11:40 -0400 Message-ID: Subject: Re: svn commit: r1383011 - /lucene/dev/trunk/solr/core/src/java/org/apache/solr/update/processor/Clon eFieldUpdateProcessorFactory.java To: dev@lucene.apache.org Content-Type: text/plain; charset=UTF-8 X-Virus-Checked: Checked by ClamAV on apache.org I was in the middle of writing a note asking you how you found this one :) Part of the problem is that this logic is in the "checkJavaDocs.py" which isnt turned on for solr, since so many packages are missing. If we could just add even barebones package-javadocs we could find more bad html: Index: build.xml =================================================================== --- build.xml (revision 1382979) +++ build.xml (working copy) @@ -551,6 +551,7 @@ + javadocs-lint: [exec] [exec] Crawl/parse... [exec] [exec] Verify... [exec] [exec] build/docs/api/overview-summary.html [exec] missing: org.apache.noggit [exec] missing: org.apache.solr [exec] missing: org.apache.solr.analysis [exec] missing: org.apache.solr.client.solrj [exec] missing: org.apache.solr.cloud [exec] missing: org.apache.solr.common [exec] missing: org.apache.solr.core [exec] missing: org.apache.solr.handler [exec] missing: org.apache.solr.handler.admin [exec] missing: org.apache.solr.handler.component [exec] missing: org.apache.solr.handler.loader [exec] missing: org.apache.solr.highlight [exec] missing: org.apache.solr.internal.csv [exec] missing: org.apache.solr.internal.csv.writer [exec] missing: org.apache.solr.logging [exec] missing: org.apache.solr.logging.jul [exec] missing: org.apache.solr.request [exec] missing: org.apache.solr.response [exec] missing: org.apache.solr.response.transform [exec] missing: org.apache.solr.schema [exec] missing: org.apache.solr.search [exec] missing: org.apache.solr.search.function [exec] missing: org.apache.solr.search.function.distance [exec] missing: org.apache.solr.search.grouping [exec] missing: org.apache.solr.search.grouping.collector [exec] missing: org.apache.solr.search.grouping.distributed [exec] missing: org.apache.solr.search.grouping.distributed.command [exec] missing: org.apache.solr.search.grouping.distributed.requestfactory [exec] missing: org.apache.solr.search.grouping.distributed.responseprocessor [exec] missing: org.apache.solr.search.grouping.distributed.shardresultserializer [exec] missing: org.apache.solr.search.grouping.endresulttransformer [exec] missing: org.apache.solr.search.similarities [exec] missing: org.apache.solr.servlet [exec] missing: org.apache.solr.servlet.cache [exec] missing: org.apache.solr.spelling [exec] missing: org.apache.solr.spelling.suggest [exec] missing: org.apache.solr.spelling.suggest.fst [exec] missing: org.apache.solr.spelling.suggest.jaspell [exec] missing: org.apache.solr.spelling.suggest.tst [exec] missing: org.apache.solr.update [exec] missing: org.apache.solr.update.processor [exec] missing: org.apache.solr.util [exec] missing: org.apache.solr.util.plugin [exec] missing: org.apache.solr.util.xslt [exec] missing: org.apache.zookeeper [exec] missing: org.apache.solr.client.solrj.beans [exec] missing: org.apache.solr.client.solrj.embedded [exec] missing: org.apache.solr.client.solrj.impl [exec] missing: org.apache.solr.client.solrj.request [exec] missing: org.apache.solr.client.solrj.response [exec] missing: org.apache.solr.client.solrj.util [exec] missing: org.apache.solr.common.cloud [exec] missing: org.apache.solr.common.luke [exec] missing: org.apache.solr.common.params [exec] missing: org.apache.solr.common.util [exec] missing: org.apache.solr.handler.clustering [exec] missing: org.apache.solr.handler.clustering.carrot2 [exec] missing: org.apache.solr.handler.dataimport [exec] missing: org.apache.solr.handler.dataimport.config [exec] missing: org.apache.solr.handler.extraction [exec] missing: org.apache.solr.uima.processor [exec] missing: org.apache.solr.uima.processor.exception [exec] [exec] build/docs/api/org/apache/solr/handler/dataimport/Context.html [exec] broken details HTML: Constructor Detail: getRequestParameters: closing "" does not match opening "" [exec] [exec] build/docs/api/org/apache/solr/handler/dataimport/XPathRecordReader.html [exec] broken details HTML: Method Detail: addField: closing "" does not match opening "" [exec] broken details HTML: Method Detail: addField: closing "" does not match opening "" [exec] [exec] build/docs/api/org/apache/solr/handler/dataimport/ContextImpl.html [exec] broken details HTML: Field Detail: getRequestParameters: closing "" does not match opening "" [exec] [exec] build/docs/api/org/apache/solr/util/plugin/AbstractPluginLoader.html [exec] broken details HTML: Field Detail: load: closing "" does not match opening "" [exec] [exec] build/docs/api/org/apache/solr/core/SolrCore.html [exec] broken details HTML: Method Detail: openNewSearcher: closing "" does not match opening "" [exec] [exec] build/docs/api/org/apache/solr/response/XMLWriter.html [exec] broken details HTML: Field Detail: writeSolrDocument: closing "" does not match opening "" [exec] [exec] build/docs/api/org/apache/solr/search/FunctionQParser.html [exec] broken details HTML: Field Detail: parseValueSourceList: closing "" does not match opening "" [exec] [exec] build/docs/api/org/apache/solr/search/QueryParsing.html [exec] broken details HTML: Field Detail: parseSort: closing "" does not match opening "" [exec] [exec] build/docs/api/org/apache/solr/search/DocIterator.html [exec] broken details HTML: Method Detail: nextDoc: closing "" does not match opening "" [exec] [exec] build/docs/api/test-framework/overview-summary.html [exec] missing: org.apache.solr [exec] missing: org.apache.solr.analysis [exec] missing: org.apache.solr.cloud [exec] missing: org.apache.solr.core [exec] missing: org.apache.solr.update.processor [exec] missing: org.apache.solr.util [exec] [exec] build/docs/api/solrj/overview-summary.html [exec] missing: org.apache.noggit [exec] missing: org.apache.solr.client.solrj [exec] missing: org.apache.solr.client.solrj.beans [exec] missing: org.apache.solr.client.solrj.impl [exec] missing: org.apache.solr.client.solrj.request [exec] missing: org.apache.solr.client.solrj.response [exec] missing: org.apache.solr.client.solrj.util [exec] missing: org.apache.solr.common [exec] missing: org.apache.solr.common.cloud [exec] missing: org.apache.solr.common.luke [exec] missing: org.apache.solr.common.params [exec] missing: org.apache.solr.common.util [exec] missing: org.apache.zookeeper [exec] [exec] Missing javadocs were found! BUILD FAILED /home/rmuir/workspace/lucene-trunk/solr/build.xml:554: The following error occurred while executing this line: /home/rmuir/workspace/lucene-trunk/lucene/common-build.xml:1813: exec returned: 1 On Mon, Sep 10, 2012 at 2:08 PM, Chris Hostetter wrote: > > folks who are versed in the details of that javadocs-lint helper script > may want to note that it did not fail on this (pre-commit) bad html (which > i thought was one of the things the javadocs-lint was suppose to be > looking for -- but if i'm missunderstanding, then feel free to ignore) > > > > : Date: Mon, 10 Sep 2012 18:05:13 -0000 > : From: hossman@apache.org > : Reply-To: dev@lucene.apache.org > : To: commits@lucene.apache.org > : Subject: svn commit: r1383011 - > : /lucene/dev/trunk/solr/core/src/java/org/apache/solr/update/processor/Clon > : eFieldUpdateProcessorFactory.java > : > : Author: hossman > : Date: Mon Sep 10 18:05:13 2012 > : New Revision: 1383011 > : > : URL: http://svn.apache.org/viewvc?rev=1383011&view=rev > : Log: > : fix un-closed html tags in javadoc > : > : Modified: > : lucene/dev/trunk/solr/core/src/java/org/apache/solr/update/processor/CloneFieldUpdateProcessorFactory.java > : > : Modified: lucene/dev/trunk/solr/core/src/java/org/apache/solr/update/processor/CloneFieldUpdateProcessorFactory.java > : URL: http://svn.apache.org/viewvc/lucene/dev/trunk/solr/core/src/java/org/apache/solr/update/processor/CloneFieldUpdateProcessorFactory.java?rev=1383011&r1=1383010&r2=1383011&view=diff > : ============================================================================== > : --- lucene/dev/trunk/solr/core/src/java/org/apache/solr/update/processor/CloneFieldUpdateProcessorFactory.java (original) > : +++ lucene/dev/trunk/solr/core/src/java/org/apache/solr/update/processor/CloneFieldUpdateProcessorFactory.java Mon Sep 10 18:05:13 2012 > : @@ -53,9 +53,9 @@ import org.slf4j.LoggerFactory; > : > : /** > : * Clones the values found in any matching source field into > : - * the configured dest field. > : + * the configured dest field. > : *

> : - * While the dest field must be a single <str>, > : + * While the dest field must be a single <str>, > : * the source fields can be configured as either: > : *

> : *
    > : > : > : > > -Hoss > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org > For additional commands, e-mail: dev-help@lucene.apache.org > -- lucidworks.com --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org For additional commands, e-mail: dev-help@lucene.apache.org