Return-Path: X-Original-To: apmail-lucene-dev-archive@www.apache.org Delivered-To: apmail-lucene-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 7BCC5D96C for ; Thu, 27 Sep 2012 22:18:00 +0000 (UTC) Received: (qmail 41816 invoked by uid 500); 27 Sep 2012 22:17:59 -0000 Delivered-To: apmail-lucene-dev-archive@lucene.apache.org Received: (qmail 41771 invoked by uid 500); 27 Sep 2012 22:17:59 -0000 Mailing-List: contact dev-help@lucene.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@lucene.apache.org Delivered-To: mailing list dev@lucene.apache.org Received: (qmail 41763 invoked by uid 99); 27 Sep 2012 22:17:59 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 27 Sep 2012 22:17:59 +0000 X-ASF-Spam-Status: No, hits=-0.7 required=5.0 tests=RCVD_IN_DNSWL_LOW,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of rcmuir@gmail.com designates 209.85.212.48 as permitted sender) Received: from [209.85.212.48] (HELO mail-vb0-f48.google.com) (209.85.212.48) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 27 Sep 2012 22:17:52 +0000 Received: by vbme21 with SMTP id e21so3174306vbm.35 for ; Thu, 27 Sep 2012 15:17:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:from:date:message-id:subject:to:content-type; bh=QcVtNFUhvpGAm7Gnpii9kvgAjF1IOHIkfPWHicjpowY=; b=ZSKmRLp8F0aNjB7UlIfWVBbqwSX7KM9SumsGu8n0ElXY5qjjgkq/nRZIQz39vWDHhT ET1AXBXPr6PZ1ZaOS61EAwFlPnDDxOfJpY0X1Nu71n9CkVxCndr1ePYw5MVcsbgf2vV7 vLpND7qGM9CLQcNDyJbhZTPDuCAKDsoATW5sRYqLs61ReQlQBOFneH8oVeSloTeY3htV Y8dURxadnVLrgR3FQEesSNkEYEx+oj2ExV1kUbkIFRRRCzWjhCLc/IFqZt6k7Av64GLp NEo2CLcU3gM68VKaYX/aKNA4NAlotacHxANYt/gqS5TWFHdJ0YcHBLkfcB07+Gmx1X9v Wuyg== Received: by 10.58.0.82 with SMTP id 18mr3177986vec.0.1348784251844; Thu, 27 Sep 2012 15:17:31 -0700 (PDT) MIME-Version: 1.0 Received: by 10.220.118.70 with HTTP; Thu, 27 Sep 2012 15:17:11 -0700 (PDT) From: Robert Muir Date: Thu, 27 Sep 2012 18:17:11 -0400 Message-ID: Subject: RE: missing javadocs/package.html To: dev@lucene.apache.org Content-Type: text/plain; charset=UTF-8 X-Virus-Checked: Checked by ClamAV on apache.org I wanted to respond to Tommaso's comment in the release vote in a separate thread for discussion: > one thing I noticed is : > "no package description (missing package.html in src?)" > for most of the Solr source code therefore we should add those package(-info).html for the javadoc. We've been working on this for the lucene side (3.6 was the first release where every package had docs, 4.0 will be the first where every class had docs, and we are now working towards methods/fields/ctors/enums). I think this would be valuable for solr too (especially solrj as a start). Besides users, its really useful to developers as well. Of course we all think our code is self-documenting, but its not always the case. a few extra seconds can save someone a ton of time trying to figure out your code. Additionally at least in my IDE, when things are done as javadoc comments then they are more easily accessible than code comments. I'm sure its the case for some other development environments too. Filling in these package.html's to at least have a one sentence description would be a really good start. It lets someone know where to go at the high-level. If I was brand new to solr and wanted to write a java app that uses solrj, i wouldn't have a clue where to start (https://builds.apache.org/job/Solr-Artifacts-4.x/javadoc/solr-solrj/index.html). 12 sentences could go a really long way. And for all new code, I hope we can all try harder for more complete javadocs. when you are working on something and its fresh in your head its a lot easier to do this than for someone else to come back around and figure it out. --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org For additional commands, e-mail: dev-help@lucene.apache.org