Return-Path: X-Original-To: apmail-lucene-dev-archive@www.apache.org Delivered-To: apmail-lucene-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 5F8A0D427 for ; Sat, 8 Sep 2012 12:42:58 +0000 (UTC) Received: (qmail 414 invoked by uid 500); 8 Sep 2012 12:42:56 -0000 Delivered-To: apmail-lucene-dev-archive@lucene.apache.org Received: (qmail 252 invoked by uid 500); 8 Sep 2012 12:42:54 -0000 Mailing-List: contact dev-help@lucene.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@lucene.apache.org Delivered-To: mailing list dev@lucene.apache.org Received: (qmail 235 invoked by uid 99); 8 Sep 2012 12:42:53 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 08 Sep 2012 12:42:53 +0000 X-ASF-Spam-Status: No, hits=-0.7 required=5.0 tests=RCVD_IN_DNSWL_LOW,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of rcmuir@gmail.com designates 209.85.212.48 as permitted sender) Received: from [209.85.212.48] (HELO mail-vb0-f48.google.com) (209.85.212.48) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 08 Sep 2012 12:42:48 +0000 Received: by vbme21 with SMTP id e21so773818vbm.35 for ; Sat, 08 Sep 2012 05:42:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :content-type:content-transfer-encoding; bh=Y9ZX3jJoH+gWK1Ts57oZ43U1Yw6lO2S9ePgJ6MlAHbo=; b=s2OApjYiPIGMSoCnulRsjk9X84hGqu5l+YAAcXRQRajobNeKVYpgwXExQHagelfHCo rRwy/TFbbDrlLdT7BnuFt0ssqshrop8L6eA/vmUapefLzZ4m/lyatXP58TpRMG41evjH 413J53ZqlxGDxkT4KEmAYIMQ4t3lOxuhsuo+FBAMHcqPeJGdPc4O1360JWn6876pNW63 niYoGAPQQA3kQGenmgpN3X82tdCeOBBN+eFrBhnldM3dSG0VJvB6QzZnruGyKRY4bMQ5 NfT04mEtdEp6qIYBAuDYP7Jz1BhxgVL2s2BSEdu1mjb1li+AZpx988PRfYTrYSGOnJGv oBrQ== Received: by 10.52.21.204 with SMTP id x12mr9002201vde.49.1347108147241; Sat, 08 Sep 2012 05:42:27 -0700 (PDT) MIME-Version: 1.0 Received: by 10.220.239.14 with HTTP; Sat, 8 Sep 2012 05:42:06 -0700 (PDT) In-Reply-To: <006001cd8dbe$a7b1c340$f71549c0$@thetaphi.de> References: <1135949755.3.1347099722015.JavaMail.jenkins@serv1.sd-datasolutions.de> <005b01cd8db8$58fc96e0$0af5c4a0$@thetaphi.de> <005c01cd8db8$91bffdf0$b53ff9d0$@thetaphi.de> <006001cd8dbe$a7b1c340$f71549c0$@thetaphi.de> From: Robert Muir Date: Sat, 8 Sep 2012 08:42:06 -0400 Message-ID: Subject: Re: [JENKINS] Lucene-Solr-trunk-Windows (64bit/jdk1.7.0_07) - Build # 673 - Failure! To: dev@lucene.apache.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Sat, Sep 8, 2012 at 8:37 AM, Uwe Schindler wrote: > The missing ones on clones are just standard Lucene behaviour. Clones are= never closed in Lucene. But we have correct support for it now (this is im= portant for CFS, as all CFS child files are just clones, so they should thr= ow AlreadyClosed after closing them), this was also missing in previous MMa= pDir. I added 2 new tests that check for clones we independent from master,= so when they are closed, other clones are unaffected. Just the close of th= e master/slicer now forcefully closes all childs. exactly: clones are SOMETIMES now closed :) In any case they are closable so it should be fine. I was just being pedantic because this test tests MMapDir directly (no MockDirWrapper). Thats why only windows caught the missing close() here. But I think its best this test use MMapDir directly. Thanks for the new tests! --=20 lucidworks.com --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org For additional commands, e-mail: dev-help@lucene.apache.org