Return-Path: X-Original-To: apmail-lucene-dev-archive@www.apache.org Delivered-To: apmail-lucene-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id E56D6D38A for ; Tue, 18 Sep 2012 17:54:08 +0000 (UTC) Received: (qmail 11937 invoked by uid 500); 18 Sep 2012 17:54:07 -0000 Delivered-To: apmail-lucene-dev-archive@lucene.apache.org Received: (qmail 11875 invoked by uid 500); 18 Sep 2012 17:54:07 -0000 Mailing-List: contact dev-help@lucene.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@lucene.apache.org Delivered-To: mailing list dev@lucene.apache.org Received: (qmail 11867 invoked by uid 99); 18 Sep 2012 17:54:07 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 18 Sep 2012 17:54:07 +0000 Date: Wed, 19 Sep 2012 04:54:07 +1100 (NCT) From: "Michael McCandless (JIRA)" To: dev@lucene.apache.org Message-ID: <655633585.93329.1347990847577.JavaMail.jiratomcat@arcas> In-Reply-To: <252891080.4782.1320595251710.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Resolved] (LUCENE-3564) rename IndexWriter.rollback to .rollbackAndClose MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/LUCENE-3564?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael McCandless resolved LUCENE-3564. ---------------------------------------- Resolution: Won't Fix Yeah I think so. Naming is the hardest part :) > rename IndexWriter.rollback to .rollbackAndClose > ------------------------------------------------ > > Key: LUCENE-3564 > URL: https://issues.apache.org/jira/browse/LUCENE-3564 > Project: Lucene - Core > Issue Type: Improvement > Reporter: Michael McCandless > Assignee: Michael McCandless > Fix For: 4.1 > > > Spinoff from LUCENE-3454, where Shai noticed that rollback is trappy since it [unexpected] closes the IW. > I think we should rename it to rollbackAndClose. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org For additional commands, e-mail: dev-help@lucene.apache.org