Return-Path: X-Original-To: apmail-lucene-dev-archive@www.apache.org Delivered-To: apmail-lucene-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id CA2D1D270 for ; Wed, 26 Sep 2012 12:45:11 +0000 (UTC) Received: (qmail 96826 invoked by uid 500); 26 Sep 2012 12:45:10 -0000 Delivered-To: apmail-lucene-dev-archive@lucene.apache.org Received: (qmail 96681 invoked by uid 500); 26 Sep 2012 12:45:09 -0000 Mailing-List: contact dev-help@lucene.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@lucene.apache.org Delivered-To: mailing list dev@lucene.apache.org Received: (qmail 96444 invoked by uid 99); 26 Sep 2012 12:45:09 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 26 Sep 2012 12:45:09 +0000 Date: Wed, 26 Sep 2012 23:45:09 +1100 (NCT) From: "Steven Rowe (JIRA)" To: dev@lucene.apache.org Message-ID: <420773229.128023.1348663509137.JavaMail.jiratomcat@arcas> In-Reply-To: <1901308971.127908.1348661107853.JavaMail.jiratomcat@arcas> Subject: [jira] [Commented] (LUCENE-4435) rethink TestCheckIndex.testLuceneConstantVersion MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/LUCENE-4435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13463765#comment-13463765 ] Steven Rowe commented on LUCENE-4435: ------------------------------------- Yeah, I have a note in {{dev-tools/maven/README.maven}}: {quote} Note: if you change the version in the POMs, there is one test method that will fail under maven-surefire-plugin: o.a.l.index.TestCheckIndex#testLuceneConstantVersion(). It's safe to @Ignore this test method, since it's just comparing the value of the lucene.version system property (set in the maven-surefire-plugin configuration in the lucene-core POM) against a hard-wired official version (o.a.l.util.Constants.LUCENE_MAIN_VERSION). {quote} > rethink TestCheckIndex.testLuceneConstantVersion > ------------------------------------------------ > > Key: LUCENE-4435 > URL: https://issues.apache.org/jira/browse/LUCENE-4435 > Project: Lucene - Core > Issue Type: Bug > Components: general/test > Reporter: Robert Muir > > This test currently checks the "display version" of lucene which is set by the ant build.xml variable. > But its been problematic in the past: and I'm sure its annoying for people running from things like IDEs. > I think LUCENE-4428 is a more straightforward way of checking that the version is set correctly, it verifies the actual JAR metadata. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org For additional commands, e-mail: dev-help@lucene.apache.org