Mailing-List: contact dev-help@lucene.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@lucene.apache.org
Date: Sat, 8 Sep 2012 08:54:07 +1100 (NCT)
From: "Hoss Man (JIRA)" <jira@apache.org>
To: dev@lucene.apache.org
Message-ID: <2064617371.52538.1347054848033.JavaMail.jiratomcat@arcas>
Subject: [jira] [Updated] (SOLR-1818) SqlEntityProcessor should do something
 (like throw an error) if DOT_PATTERN is not matched
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


     [ https://issues.apache.org/jira/browse/SOLR-1818?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Hoss Man updated SOLR-1818:
---------------------------

    Fix Version/s:     (was: 4.0)
         Assignee: James Dyer

removing fixVersion=4.0 since there is no evidence that anyone is currently working on this issue.  (this can certainly be revisited if volunteers step forward)

also assigning to james in the hopes that he can give a quick assement wether there is an easy improvment to deal with this
                
> SqlEntityProcessor should do something (like throw an error) if DOT_PATTERN is not matched
> ------------------------------------------------------------------------------------------
>
>                 Key: SOLR-1818
>                 URL: https://issues.apache.org/jira/browse/SOLR-1818
>             Project: Solr
>          Issue Type: Bug
>          Components: contrib - DataImportHandler
>            Reporter: Mark Miller
>            Assignee: James Dyer
>            Priority: Trivial
>
> Looking like we should do something if DOT_PATTERN does not match a primary key (rather then get the resulting nullpointer exception) - I'm not really up on DIH, so I'm not sure if that is something we never expect to see, but even in that case it might be nice to add an else throw illegalstate or something with a "we should never get here" comment - just for future DIH devs.
> {code}
>       Object val = context.resolve("dataimporter.delta." + primaryKey);
>       if (val == null) {
>         Matcher m = DOT_PATTERN.matcher(primaryKey);
>         if (m.find()) {
>           val = context.resolve("dataimporter.delta." + m.group(1));
>         }
>       }
>       sb.append(primaryKey).append(" = ");
>       if (val instanceof Number) {
>         sb.append(val.toString());
>       } else {
>         sb.append("'").append(val.toString()).append("'");
>       }
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org