Return-Path: X-Original-To: apmail-lucene-dev-archive@www.apache.org Delivered-To: apmail-lucene-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 3E600DB99 for ; Thu, 13 Sep 2012 22:34:09 +0000 (UTC) Received: (qmail 84917 invoked by uid 500); 13 Sep 2012 22:34:07 -0000 Delivered-To: apmail-lucene-dev-archive@lucene.apache.org Received: (qmail 84813 invoked by uid 500); 13 Sep 2012 22:34:07 -0000 Mailing-List: contact dev-help@lucene.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@lucene.apache.org Delivered-To: mailing list dev@lucene.apache.org Received: (qmail 84733 invoked by uid 99); 13 Sep 2012 22:34:07 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 13 Sep 2012 22:34:07 +0000 Date: Fri, 14 Sep 2012 09:34:07 +1100 (NCT) From: "Hoss Man (JIRA)" To: dev@lucene.apache.org Message-ID: <2053894008.77678.1347575647835.JavaMail.jiratomcat@arcas> In-Reply-To: <257305119.68822.1347448087805.JavaMail.jiratomcat@arcas> Subject: [jira] [Resolved] (SOLR-3828) Query Elevation component boosts excluded results in markExcludes mode MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/SOLR-3828?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hoss Man resolved SOLR-3828. ---------------------------- Resolution: Fixed Fix Version/s: 5.0 Assignee: Hoss Man Looking back at SOLR-2977 and r1222234 where these lines of code were added, i think it was just a brain fart on grant's part -- he introduced a code branch in a place where (previously) BooleanClauses were always added with MUST_NOT and now that he didn't wnat to actaully exclude them, just mark them, he cloned that code and had it use SHOULD instead. but i agree, that doesn't make any sense -- the set of results using markExclude=true should be the same as the set of results you get not using the elevation component at all, and the scores of the excluded docs shouldn't change. Committed revision 1384567. Committed revision 1384577. - 4x Thanks for finding this and providing the test alexey! > Query Elevation component boosts excluded results in markExcludes mode > ---------------------------------------------------------------------- > > Key: SOLR-3828 > URL: https://issues.apache.org/jira/browse/SOLR-3828 > Project: Solr > Issue Type: Bug > Components: SearchComponents - other > Affects Versions: 4.0-BETA > Reporter: Alexey Serba > Assignee: Hoss Man > Priority: Trivial > Fix For: 4.0, 5.0 > > Attachments: SOLR-3828.patch > > > Query Elevation component boosts excluded results in markExcludes=true mode causing them to be higher on results than they should. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org For additional commands, e-mail: dev-help@lucene.apache.org