Return-Path: X-Original-To: apmail-lucene-dev-archive@www.apache.org Delivered-To: apmail-lucene-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id EECCED91F for ; Fri, 28 Sep 2012 01:29:08 +0000 (UTC) Received: (qmail 72532 invoked by uid 500); 28 Sep 2012 01:29:07 -0000 Delivered-To: apmail-lucene-dev-archive@lucene.apache.org Received: (qmail 72291 invoked by uid 500); 28 Sep 2012 01:29:07 -0000 Mailing-List: contact dev-help@lucene.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@lucene.apache.org Delivered-To: mailing list dev@lucene.apache.org Received: (qmail 72282 invoked by uid 99); 28 Sep 2012 01:29:07 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 28 Sep 2012 01:29:07 +0000 Date: Fri, 28 Sep 2012 12:29:07 +1100 (NCT) From: "Robert Muir (JIRA)" To: dev@lucene.apache.org Message-ID: <1868949144.137113.1348795747669.JavaMail.jiratomcat@arcas> Subject: [jira] [Created] (LUCENE-4443) BlockPostingsFormat writes unnecessary skipdata MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 Robert Muir created LUCENE-4443: ----------------------------------- Summary: BlockPostingsFormat writes unnecessary skipdata Key: LUCENE-4443 URL: https://issues.apache.org/jira/browse/LUCENE-4443 Project: Lucene - Core Issue Type: Bug Components: core/codecs Affects Versions: 4.0 Reporter: Robert Muir Fix For: 4.1 Attachments: LUCENE-4443.patch Seems to me lastStartOffset is unnecessary, when we skip to a document, it implicitly is 0: see BlockPostingsWriter.startDoc. (Unless I'm missing something, all tests pass with "Block" if i remove it) Separately we should really think about lastPayloadByteUpto, is this worth it? instead when we actually skip, we could sum the payloadLengthBuffer from 0..curPosBufferUpto as we are going to decode that block anyway? -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org For additional commands, e-mail: dev-help@lucene.apache.org