Return-Path: X-Original-To: apmail-lucene-dev-archive@www.apache.org Delivered-To: apmail-lucene-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 835A1D995 for ; Wed, 12 Sep 2012 12:31:11 +0000 (UTC) Received: (qmail 80218 invoked by uid 500); 12 Sep 2012 12:31:10 -0000 Delivered-To: apmail-lucene-dev-archive@lucene.apache.org Received: (qmail 79963 invoked by uid 500); 12 Sep 2012 12:31:09 -0000 Mailing-List: contact dev-help@lucene.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@lucene.apache.org Delivered-To: mailing list dev@lucene.apache.org Received: (qmail 79906 invoked by uid 99); 12 Sep 2012 12:31:08 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 12 Sep 2012 12:31:08 +0000 Date: Wed, 12 Sep 2012 23:31:08 +1100 (NCT) From: "Robert Muir (JIRA)" To: dev@lucene.apache.org Message-ID: <1785585173.69087.1347453068053.JavaMail.jiratomcat@arcas> In-Reply-To: <1501049451.66689.1347407767891.JavaMail.jiratomcat@arcas> Subject: [jira] [Resolved] (LUCENE-4377) consolidate various copyBytes() methods MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/LUCENE-4377?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir resolved LUCENE-4377. --------------------------------- Resolution: Fixed > consolidate various copyBytes() methods > --------------------------------------- > > Key: LUCENE-4377 > URL: https://issues.apache.org/jira/browse/LUCENE-4377 > Project: Lucene - Core > Issue Type: Bug > Reporter: Robert Muir > Assignee: Robert Muir > Fix For: 5.0, 4.0 > > Attachments: LUCENE-4377.patch > > > Spinoff of LUCENE-4371: > {quote} > I don't think the default impl (SlicedIndexInput) should overrided BII's copyBytes? Seems ... spooky. > {quote} > There are copyBytes everywhere, mostly not really being used. > Particularly DataOutput.copyBytes(DataInput) versus IndexInput.copyBytes(IndexOutput). > Bulk merging already uses DataOutput.copyBytes(DataInput), its the most general (as it works on DataInput/Output), and its in dst, src order. > I think we should remove IndexInput.copyBytes, its not necessary. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org For additional commands, e-mail: dev-help@lucene.apache.org