Mailing-List: contact dev-help@lucene.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@lucene.apache.org
Date: Fri, 28 Sep 2012 23:10:07 +1100 (NCT)
From: "Michael McCandless (JIRA)" <jira@apache.org>
To: dev@lucene.apache.org
Message-ID: <1739078080.138772.1348834208005.JavaMail.jiratomcat@arcas>
In-Reply-To: <1868949144.137113.1348795747669.JavaMail.jiratomcat@arcas>
Subject: [jira] [Commented] (LUCENE-4443) BlockPostingsFormat writes
 unnecessary skipdata
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/LUCENE-4443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13465550#comment-13465550 ] 

Michael McCandless commented on LUCENE-4443:
--------------------------------------------

+1 to nuke lastStartOffset: it's pointless!

I'm torn on nuking lastPayloadByteUpto ...
                
> BlockPostingsFormat writes unnecessary skipdata
> -----------------------------------------------
>
>                 Key: LUCENE-4443
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4443
>             Project: Lucene - Core
>          Issue Type: Bug
>          Components: core/codecs
>    Affects Versions: 4.0
>            Reporter: Robert Muir
>             Fix For: 4.1
>
>         Attachments: LUCENE-4443.patch
>
>
> Seems to me lastStartOffset is unnecessary, when we skip to a document, it implicitly is 0: see BlockPostingsWriter.startDoc.
> (Unless I'm missing something, all tests pass with "Block" if i remove it)
> Separately we should really think about lastPayloadByteUpto, is this worth it? instead when we actually skip, we could sum the payloadLengthBuffer from 0..curPosBufferUpto as we are going to decode that block anyway?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org