Return-Path: 
 <dev-return-110344-apmail-lucene-dev-archive=lucene.apache.org@lucene.apache.org>
X-Original-To: apmail-lucene-dev-archive@www.apache.org
Delivered-To: apmail-lucene-dev-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id DB34FD36D
	for <apmail-lucene-dev-archive@www.apache.org>;
 Tue, 25 Sep 2012 12:50:09 +0000 (UTC)
Received: (qmail 85161 invoked by uid 500); 25 Sep 2012 12:50:08 -0000
Delivered-To: apmail-lucene-dev-archive@lucene.apache.org
Received: (qmail 85084 invoked by uid 500); 25 Sep 2012 12:50:08 -0000
Mailing-List: contact dev-help@lucene.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@lucene.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@lucene.apache.org>
List-Post: <mailto:dev@lucene.apache.org>
List-Id: <dev.lucene.apache.org>
Reply-To: dev@lucene.apache.org
Delivered-To: mailing list dev@lucene.apache.org
Received: (qmail 85063 invoked by uid 99); 25 Sep 2012 12:50:07 -0000
Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 25 Sep 2012 12:50:07 +0000
Date: Tue, 25 Sep 2012 23:50:07 +1100 (NCT)
From: "Robert Muir (JIRA)" <jira@apache.org>
To: dev@lucene.apache.org
Message-ID: <1577930764.121752.1348577407581.JavaMail.jiratomcat@arcas>
In-Reply-To: <1910121374.118586.1348519808154.JavaMail.jiratomcat@arcas>
Subject: [jira] [Commented] (LUCENE-4423)
 DocumentStoredFieldVisitor.binaryField ignores offset and length
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394


    [ https://issues.apache.org/jira/browse/LUCENE-4423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13462708#comment-13462708 ] 

Robert Muir commented on LUCENE-4423:
-------------------------------------

Its also possible to add a test for this issue: we could do it either in AssertingCodec or AssertingAtomicReader,
have it copy the bytes to a new byte[] { "BOGUS" + <original> } and set the offset/length.

This way we know if any visitors are broken. (even though the current offset and length are superfluous imo,
we should ensure visitors respect the contract).
                
> DocumentStoredFieldVisitor.binaryField ignores offset and length
> ----------------------------------------------------------------
>
>                 Key: LUCENE-4423
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4423
>             Project: Lucene - Core
>          Issue Type: Bug
>          Components: core/store
>            Reporter: Adrien Grand
>         Attachments: LUCENE-4423.patch, LUCENE-4423.patch
>
>
> This is no problem with SimpleText and Lucene40 since in their cases, offset is always 0 and length the length of the byte[] array, but it might break with custom codecs.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org