Return-Path: 
 <dev-return-109379-apmail-lucene-dev-archive=lucene.apache.org@lucene.apache.org>
X-Original-To: apmail-lucene-dev-archive@www.apache.org
Delivered-To: apmail-lucene-dev-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id C6B98D819
	for <apmail-lucene-dev-archive@www.apache.org>;
 Mon, 17 Sep 2012 14:43:09 +0000 (UTC)
Received: (qmail 47864 invoked by uid 500); 17 Sep 2012 14:43:08 -0000
Delivered-To: apmail-lucene-dev-archive@lucene.apache.org
Received: (qmail 47795 invoked by uid 500); 17 Sep 2012 14:43:08 -0000
Mailing-List: contact dev-help@lucene.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@lucene.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@lucene.apache.org>
List-Post: <mailto:dev@lucene.apache.org>
List-Id: <dev.lucene.apache.org>
Reply-To: dev@lucene.apache.org
Delivered-To: mailing list dev@lucene.apache.org
Received: (qmail 47786 invoked by uid 99); 17 Sep 2012 14:43:08 -0000
Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 17 Sep 2012 14:43:08 +0000
Date: Tue, 18 Sep 2012 01:43:08 +1100 (NCT)
From: "Jack Krupansky (JIRA)" <jira@apache.org>
To: dev@lucene.apache.org
Message-ID: <1514650855.87899.1347892988241.JavaMail.jiratomcat@arcas>
In-Reply-To: <798235283.37323.1346820427985.JavaMail.jiratomcat@arcas>
Subject: [jira] [Commented] (LUCENE-4362) ban tab-indented source
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394


    [ https://issues.apache.org/jira/browse/LUCENE-4362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13457059#comment-13457059 ] 

Jack Krupansky commented on LUCENE-4362:
----------------------------------------

Is this issue for 5.0 only or for 4.0 as well? No "Fix Version" is listed, but I do see a "4x" patch.
                
> ban tab-indented source
> -----------------------
>
>                 Key: LUCENE-4362
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4362
>             Project: Lucene - Core
>          Issue Type: Task
>            Reporter: Robert Muir
>            Assignee: Erick Erickson
>         Attachments: LUCENE-4326_trunk.patch, LUCENE-4362_4x.patch, LUCENE-4362_4x.patch, LUCENE-4362_4x.patch, LUCENE-4362_4x.patch, LUCENE-4362_core.patch, LUCENE-4362.patch, LUCENE-4362.patch, LUCENE-4362_trunk.patch, LUCENE-4362_trunk.patch
>
>
> This makes code really difficult to read and work with.
> Its easy enough to prevent.
> {noformat}
> Index: build.xml
> ===================================================================
> --- build.xml	(revision 1380979)
> +++ build.xml	(working copy)
> @@ -77,11 +77,12 @@
>          <or>
>            <containsregexp expression="@author\b" casesensitive="yes"/>
>            <containsregexp expression="\bno(n|)commit\b" casesensitive="no"/>
> +          <containsregexp expression="\t" casesensitive="no"/>
>          </or>
>        </fileset>
>        <map from="${validate.currDir}${file.separator}" to="* "/>
>      </pathconvert>
> -    <fail if="validate.patternsFound">The following files contain @author tags or nocommits:${line.separator}${validate.patternsFound}</fail>
> +    <fail if="validate.patternsFound">The following files contain @author tags, tabs or nocommits:${line.separator}${validate.patternsFound}</fail>
>    </target>
> {noformat}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org