Mailing-List: contact dev-help@lucene.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@lucene.apache.org
Date: Thu, 13 Sep 2012 01:17:08 +1100 (NCT)
From: "Robert Muir (JIRA)" <jira@apache.org>
To: dev@lucene.apache.org
Message-ID: <1504621282.69510.1347459428201.JavaMail.jiratomcat@arcas>
In-Reply-To: <2075184231.69507.1347459427997.JavaMail.jiratomcat@arcas>
Subject: [jira] [Updated] (LUCENE-4380) fix simplefs/niofshierarchy
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


     [ https://issues.apache.org/jira/browse/LUCENE-4380?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robert Muir updated LUCENE-4380:
--------------------------------

    Attachment: LUCENE-4380.patch

Here's a patch: i factored the shared logic into an FSIndexInput (parallel with FSIndexOutput) instead.
                
> fix simplefs/niofshierarchy
> ---------------------------
>
>                 Key: LUCENE-4380
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4380
>             Project: Lucene - Core
>          Issue Type: Task
>            Reporter: Robert Muir
>         Attachments: LUCENE-4380.patch
>
>
> spinoff from LUCENE-4371:
> Currently NIOFSDirectory.NIOFSIndexInput extends SimpleFSDirectory.SimpleFSIndexInput, but this isn't an is-a relationship at all.
> Additionally SimpleFSDirectory has a funky Descriptor class that extends RandomAccessFile that is useless:
> {noformat}
>     /**
>      * Extension of RandomAccessFile that tracks if the file is 
>      * open.
>      */
> ...
>       // remember if the file is open, so that we don't try to close it
>       // more than once
> {noformat}
> RandomAccessFile is closeable, this is not necessary and I don't think we should be subclassing it.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org