Mailing-List: contact dev-help@lucene.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@lucene.apache.org
Date: Thu, 6 Sep 2012 12:40:07 +1100 (NCT)
From: "Hoss Man (JIRA)" <jira@apache.org>
To: dev@lucene.apache.org
Message-ID: <1272596178.42578.1346895607705.JavaMail.jiratomcat@arcas>
In-Reply-To: <1704874118.42361.1346892368566.JavaMail.jiratomcat@arcas>
Subject: [jira] [Updated] (SOLR-3795) /admin/luke?show=schema is returning
 raw toString of SchemaField and CopyField objects for "copyDests" and
 "copySources"
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


     [ https://issues.apache.org/jira/browse/SOLR-3795?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Hoss Man updated SOLR-3795:
---------------------------

    Attachment: SOLR-3795.patch

patch that fixes LukeRequestHandler to return just the names for copyDests and copySources and includes a test case (part of which is commented out because of SOLR-3798)

amazingly: this change doesn't totally break the admin ui, which leads me to believe steffkes is even more awesome then i realized, and must have made it assume the strings re field names it if can't "parse" them using the bogus absurd "toString" format.

I consider this a bug fix, and would definitley like to commit unless stefkes says that it does in fact break the UI in some way i'm not yet realizing.


> /admin/luke?show=schema is returning raw toString of SchemaField and CopyField objects for "copyDests" and "copySources"
> ------------------------------------------------------------------------------------------------------------------------
>
>                 Key: SOLR-3795
>                 URL: https://issues.apache.org/jira/browse/SOLR-3795
>             Project: Solr
>          Issue Type: Bug
>          Components: web gui
>            Reporter: Hoss Man
>             Fix For: 4.0
>
>         Attachments: SOLR-3795.patch
>
>
> While looking into SOLR-3734 i noticed that the LukeRequestHandler is blindly putting arrays of CopyField and SchemaField objects in the response, when returning copy from/to info, which are then getting written out using their toString.
> steffkes seems to have done a great job of parsing the field name out of the SchemaField.toString, but the CopyField.toString info is useless -- and clients shouldn't have to do special string parsing to pull out this info.
> I think we should just fix both of these arrays to just be the simple string values that they were most likely intended to be

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org