Return-Path: X-Original-To: apmail-lucene-dev-archive@www.apache.org Delivered-To: apmail-lucene-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 6F41BDB2E for ; Tue, 25 Sep 2012 22:28:10 +0000 (UTC) Received: (qmail 92471 invoked by uid 500); 25 Sep 2012 22:28:08 -0000 Delivered-To: apmail-lucene-dev-archive@lucene.apache.org Received: (qmail 92409 invoked by uid 500); 25 Sep 2012 22:28:08 -0000 Mailing-List: contact dev-help@lucene.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@lucene.apache.org Delivered-To: mailing list dev@lucene.apache.org Received: (qmail 92356 invoked by uid 99); 25 Sep 2012 22:28:08 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 25 Sep 2012 22:28:08 +0000 Date: Wed, 26 Sep 2012 09:28:08 +1100 (NCT) From: "Uwe Schindler (JIRA)" To: dev@lucene.apache.org Message-ID: <1160688083.125516.1348612088211.JavaMail.jiratomcat@arcas> In-Reply-To: <186103713.125324.1348609927906.JavaMail.jiratomcat@arcas> Subject: [jira] [Commented] (LUCENE-4430) Lucene Demo module should not ship with servlet-api.jar file MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/LUCENE-4430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13463288#comment-13463288 ] Uwe Schindler commented on LUCENE-4430: --------------------------------------- Committed trunk r1390194, 4.x r1390195, 4.0 r1390196 I keep this issue open for Mike to add the solr checks, too. > Lucene Demo module should not ship with servlet-api.jar file > ------------------------------------------------------------ > > Key: LUCENE-4430 > URL: https://issues.apache.org/jira/browse/LUCENE-4430 > Project: Lucene - Core > Issue Type: Bug > Components: modules/other > Affects Versions: 4.0-BETA > Reporter: Uwe Schindler > Assignee: Uwe Schindler > Priority: Blocker > Fix For: 4.1, 5.0, 4.0 > > Attachments: LUCENE-4430.patch > > > As noted in SOLR-3879, Mike's new check in the smoketester found out that Lucene's binary release ships with a servlet-api.jar file in the Lucene demo module. This file is an interface-only file and is provided by the servlet container where you would run the webapp. > This file should be removed from the binary release (the License is also questionable, because the "original" Sun License of servlet-api.jar was CDDL, although thats unimportant because it is an API definition file and not a implementation with actual program code. Shipping any binary code with servlet-api.jar is as wrong as shipping a Java project with JDK's rt.jar bundled). > In general we should (in another issue) restructure our lib folders and differentiate (using IVY configs) between compile-time dependencies and run-time dependencies. Servlet-api.jar is a typical example for a pure-compile-time dep. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org For additional commands, e-mail: dev-help@lucene.apache.org