Return-Path: X-Original-To: apmail-lucene-dev-archive@www.apache.org Delivered-To: apmail-lucene-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 4A504D8B8 for ; Mon, 17 Sep 2012 15:04:09 +0000 (UTC) Received: (qmail 23880 invoked by uid 500); 17 Sep 2012 15:04:08 -0000 Delivered-To: apmail-lucene-dev-archive@lucene.apache.org Received: (qmail 23822 invoked by uid 500); 17 Sep 2012 15:04:08 -0000 Mailing-List: contact dev-help@lucene.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@lucene.apache.org Delivered-To: mailing list dev@lucene.apache.org Received: (qmail 23814 invoked by uid 99); 17 Sep 2012 15:04:08 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 17 Sep 2012 15:04:08 +0000 Date: Tue, 18 Sep 2012 02:04:07 +1100 (NCT) From: "Robert Muir (JIRA)" To: dev@lucene.apache.org Message-ID: <1057898767.87948.1347894248006.JavaMail.jiratomcat@arcas> In-Reply-To: <395556876.87885.1347892627665.JavaMail.jiratomcat@arcas> Subject: [jira] [Commented] (LUCENE-4399) Rename AppendingCodec to Appending40Codec MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/LUCENE-4399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13457070#comment-13457070 ] Robert Muir commented on LUCENE-4399: ------------------------------------- I wasn't saying i was totally against the idea btw, i was just trying to invite some discussion..., just to explain my rationale: Personally I dont think its that great we have version numbers in our default codec, I was the one that proposed this because its simple on our end as Lucene developers to implement backwards compatibility this way: but it encourages some code duplication and stuff like that: which is in my mind, a lesser evil than conditionals inside one "mega-impl" like before, that must handle different binary formats. And i think this is pretty contained to expert users: most people will just create an indexwriter and be oblivious to this. As far as alternative things in codecs/, I feel it would be best to not add complication for back-compat, instead to try to keep these implementations simple. If we start adding versioning and back compat to them, then we are basically expanding our backwards compatibility commitments to N versions * M formats, which is something that requires a very big discussion. > Rename AppendingCodec to Appending40Codec > ----------------------------------------- > > Key: LUCENE-4399 > URL: https://issues.apache.org/jira/browse/LUCENE-4399 > Project: Lucene - Core > Issue Type: New Feature > Reporter: Adrien Grand > Assignee: Adrien Grand > Priority: Minor > Fix For: 4.0 > > > In order AppendingCodec to follow Lucene codecs version, I think its name should include a version number (so that, for example, if we get to releave Lucene 4.3 with a new Lucene43Codec, there will also be a new Appending43Codec). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org For additional commands, e-mail: dev-help@lucene.apache.org