lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Robert Muir <rcm...@gmail.com>
Subject Re: Purpose of CachingCollector.create(boolean, boolean, double) ?
Date Mon, 10 Sep 2012 14:36:02 GMT
fwiw, this method is only used by tests. I think we could safely
remove it and just have those tests (TestCachingCollector and one
grouping test) provide whatever collector they need instead.

On Mon, Sep 10, 2012 at 10:33 AM, Robert Muir <rcmuir@gmail.com> wrote:
> I'm looking at this code and a little confused:
>
> this wraps a no-op collector, so what happens if the maxRAMMB is
> exceeded? It seems to me in that case those hits would just be
> silently dropped?!
>
> Is this intentional?


-- 
lucidworks.com

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message