lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Robert Muir <rcm...@gmail.com>
Subject Re: svn commit: r1383011 - /lucene/dev/trunk/solr/core/src/java/org/apache/solr/update/processor/Clon eFieldUpdateProcessorFactory.java
Date Mon, 10 Sep 2012 18:11:40 GMT
I was in the middle of writing a note asking you how you found this one :)

Part of the problem is that this logic is in the "checkJavaDocs.py"
which isnt turned on for solr, since so many packages are missing. If
we could just add even barebones package-javadocs we could find more
bad html:

Index: build.xml
===================================================================
--- build.xml	(revision 1382979)
+++ build.xml	(working copy)
@@ -551,6 +551,7 @@
   <!-- TODO: also integrate checkJavaDocs.py, which does more checks -->
   <target name="javadocs-lint" depends="javadocs">
     <check-broken-links dir="build/docs"/>
+    <check-missing-javadocs dir="build/docs" level="package"/>
   </target>

   <!-- install-maven-tasks is *not* a useless dependency. do not remove -->


javadocs-lint:
     [exec]
     [exec] Crawl/parse...
     [exec]
     [exec] Verify...
     [exec]
     [exec] build/docs/api/overview-summary.html
     [exec]   missing: org.apache.noggit
     [exec]   missing: org.apache.solr
     [exec]   missing: org.apache.solr.analysis
     [exec]   missing: org.apache.solr.client.solrj
     [exec]   missing: org.apache.solr.cloud
     [exec]   missing: org.apache.solr.common
     [exec]   missing: org.apache.solr.core
     [exec]   missing: org.apache.solr.handler
     [exec]   missing: org.apache.solr.handler.admin
     [exec]   missing: org.apache.solr.handler.component
     [exec]   missing: org.apache.solr.handler.loader
     [exec]   missing: org.apache.solr.highlight
     [exec]   missing: org.apache.solr.internal.csv
     [exec]   missing: org.apache.solr.internal.csv.writer
     [exec]   missing: org.apache.solr.logging
     [exec]   missing: org.apache.solr.logging.jul
     [exec]   missing: org.apache.solr.request
     [exec]   missing: org.apache.solr.response
     [exec]   missing: org.apache.solr.response.transform
     [exec]   missing: org.apache.solr.schema
     [exec]   missing: org.apache.solr.search
     [exec]   missing: org.apache.solr.search.function
     [exec]   missing: org.apache.solr.search.function.distance
     [exec]   missing: org.apache.solr.search.grouping
     [exec]   missing: org.apache.solr.search.grouping.collector
     [exec]   missing: org.apache.solr.search.grouping.distributed
     [exec]   missing: org.apache.solr.search.grouping.distributed.command
     [exec]   missing:
org.apache.solr.search.grouping.distributed.requestfactory
     [exec]   missing:
org.apache.solr.search.grouping.distributed.responseprocessor
     [exec]   missing:
org.apache.solr.search.grouping.distributed.shardresultserializer
     [exec]   missing: org.apache.solr.search.grouping.endresulttransformer
     [exec]   missing: org.apache.solr.search.similarities
     [exec]   missing: org.apache.solr.servlet
     [exec]   missing: org.apache.solr.servlet.cache
     [exec]   missing: org.apache.solr.spelling
     [exec]   missing: org.apache.solr.spelling.suggest
     [exec]   missing: org.apache.solr.spelling.suggest.fst
     [exec]   missing: org.apache.solr.spelling.suggest.jaspell
     [exec]   missing: org.apache.solr.spelling.suggest.tst
     [exec]   missing: org.apache.solr.update
     [exec]   missing: org.apache.solr.update.processor
     [exec]   missing: org.apache.solr.util
     [exec]   missing: org.apache.solr.util.plugin
     [exec]   missing: org.apache.solr.util.xslt
     [exec]   missing: org.apache.zookeeper
     [exec]   missing: org.apache.solr.client.solrj.beans
     [exec]   missing: org.apache.solr.client.solrj.embedded
     [exec]   missing: org.apache.solr.client.solrj.impl
     [exec]   missing: org.apache.solr.client.solrj.request
     [exec]   missing: org.apache.solr.client.solrj.response
     [exec]   missing: org.apache.solr.client.solrj.util
     [exec]   missing: org.apache.solr.common.cloud
     [exec]   missing: org.apache.solr.common.luke
     [exec]   missing: org.apache.solr.common.params
     [exec]   missing: org.apache.solr.common.util
     [exec]   missing: org.apache.solr.handler.clustering
     [exec]   missing: org.apache.solr.handler.clustering.carrot2
     [exec]   missing: org.apache.solr.handler.dataimport
     [exec]   missing: org.apache.solr.handler.dataimport.config
     [exec]   missing: org.apache.solr.handler.extraction
     [exec]   missing: org.apache.solr.uima.processor
     [exec]   missing: org.apache.solr.uima.processor.exception
     [exec]
     [exec] build/docs/api/org/apache/solr/handler/dataimport/Context.html
     [exec]   broken details HTML: Constructor Detail:
getRequestParameters: closing "</div>" does not match opening
"<String>"
     [exec]
     [exec] build/docs/api/org/apache/solr/handler/dataimport/XPathRecordReader.html
     [exec]   broken details HTML: Method Detail: addField: closing
"</dd>" does not match opening "<String>"
     [exec]   broken details HTML: Method Detail: addField: closing
"</dd>" does not match opening "<String>"
     [exec]
     [exec] build/docs/api/org/apache/solr/handler/dataimport/ContextImpl.html
     [exec]   broken details HTML: Field Detail: getRequestParameters:
closing "</div>" does not match opening "<String>"
     [exec]
     [exec] build/docs/api/org/apache/solr/util/plugin/AbstractPluginLoader.html
     [exec]   broken details HTML: Field Detail: load: closing
"</div>" does not match opening "<plugin name="name2"
class="solr.ClassName" default="true">"
     [exec]
     [exec] build/docs/api/org/apache/solr/core/SolrCore.html
     [exec]   broken details HTML: Method Detail: openNewSearcher:
closing "</div>" does not match opening "<SolrIndexSearcher>"
     [exec]
     [exec] build/docs/api/org/apache/solr/response/XMLWriter.html
     [exec]   broken details HTML: Field Detail: writeSolrDocument:
closing "</div>" does not match opening "<arr>"
     [exec]
     [exec] build/docs/api/org/apache/solr/search/FunctionQParser.html
     [exec]   broken details HTML: Field Detail: parseValueSourceList:
closing "</dd>" does not match opening "<ValueSource>"
     [exec]
     [exec] build/docs/api/org/apache/solr/search/QueryParsing.html
     [exec]   broken details HTML: Field Detail: parseSort: closing
"</pre>" does not match opening "<fieldname>"
     [exec]
     [exec] build/docs/api/org/apache/solr/search/DocIterator.html
     [exec]   broken details HTML: Method Detail: nextDoc: closing
"</div>" does not match opening "<code>"
     [exec]
     [exec] build/docs/api/test-framework/overview-summary.html
     [exec]   missing: org.apache.solr
     [exec]   missing: org.apache.solr.analysis
     [exec]   missing: org.apache.solr.cloud
     [exec]   missing: org.apache.solr.core
     [exec]   missing: org.apache.solr.update.processor
     [exec]   missing: org.apache.solr.util
     [exec]
     [exec] build/docs/api/solrj/overview-summary.html
     [exec]   missing: org.apache.noggit
     [exec]   missing: org.apache.solr.client.solrj
     [exec]   missing: org.apache.solr.client.solrj.beans
     [exec]   missing: org.apache.solr.client.solrj.impl
     [exec]   missing: org.apache.solr.client.solrj.request
     [exec]   missing: org.apache.solr.client.solrj.response
     [exec]   missing: org.apache.solr.client.solrj.util
     [exec]   missing: org.apache.solr.common
     [exec]   missing: org.apache.solr.common.cloud
     [exec]   missing: org.apache.solr.common.luke
     [exec]   missing: org.apache.solr.common.params
     [exec]   missing: org.apache.solr.common.util
     [exec]   missing: org.apache.zookeeper
     [exec]
     [exec] Missing javadocs were found!

BUILD FAILED
/home/rmuir/workspace/lucene-trunk/solr/build.xml:554: The following
error occurred while executing this line:
/home/rmuir/workspace/lucene-trunk/lucene/common-build.xml:1813: exec
returned: 1


On Mon, Sep 10, 2012 at 2:08 PM, Chris Hostetter
<hossman_lucene@fucit.org> wrote:
>
> folks who are versed in the details of that javadocs-lint helper script
> may want to note that it did not fail on this (pre-commit) bad html (which
> i thought was one of the things the javadocs-lint was suppose to be
> looking for -- but if i'm missunderstanding, then feel free to ignore)
>
>
>
> : Date: Mon, 10 Sep 2012 18:05:13 -0000
> : From: hossman@apache.org
> : Reply-To: dev@lucene.apache.org
> : To: commits@lucene.apache.org
> : Subject: svn commit: r1383011 -
> :     /lucene/dev/trunk/solr/core/src/java/org/apache/solr/update/processor/Clon
> :     eFieldUpdateProcessorFactory.java
> :
> : Author: hossman
> : Date: Mon Sep 10 18:05:13 2012
> : New Revision: 1383011
> :
> : URL: http://svn.apache.org/viewvc?rev=1383011&view=rev
> : Log:
> : fix un-closed html tags in javadoc
> :
> : Modified:
> :     lucene/dev/trunk/solr/core/src/java/org/apache/solr/update/processor/CloneFieldUpdateProcessorFactory.java
> :
> : Modified: lucene/dev/trunk/solr/core/src/java/org/apache/solr/update/processor/CloneFieldUpdateProcessorFactory.java
> : URL: http://svn.apache.org/viewvc/lucene/dev/trunk/solr/core/src/java/org/apache/solr/update/processor/CloneFieldUpdateProcessorFactory.java?rev=1383011&r1=1383010&r2=1383011&view=diff
> : ==============================================================================
> : --- lucene/dev/trunk/solr/core/src/java/org/apache/solr/update/processor/CloneFieldUpdateProcessorFactory.java
(original)
> : +++ lucene/dev/trunk/solr/core/src/java/org/apache/solr/update/processor/CloneFieldUpdateProcessorFactory.java
Mon Sep 10 18:05:13 2012
> : @@ -53,9 +53,9 @@ import org.slf4j.LoggerFactory;
> :
> :  /**
> :   * Clones the values found in any matching <code>source</code> field into
> : - * the configured <code>dest<code> field.
> : + * the configured <code>dest</code> field.
> :   * <p>
> : - * While the <code>dest<code> field must be a single <code>&lt;str&gt;</code>,
> : + * While the <code>dest</code> field must be a single <code>&lt;str&gt;</code>,
> :   * the <code>source</code> fields can be configured as either:
> :   * </p>
> :   * <ul>
> :
> :
> :
>
> -Hoss
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
> For additional commands, e-mail: dev-help@lucene.apache.org
>



-- 
lucidworks.com

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message