lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Erick Erickson <erickerick...@gmail.com>
Subject Re: [jira] [Commented] (LUCENE-4362) ban tab-indented source
Date Thu, 06 Sep 2012 16:18:36 GMT
Java files matching anything ending in .jj or .jflex, right?

Yep, I changed one of the java files once, I think McCandless rescued me....

I'll make it so, but just to verify that I'm not going off the deep
end again, the process will be to modify the .jj or .jflex files to
remove tabs, regenerate the java and check _both_ back in?

Erick

On Thu, Sep 6, 2012 at 9:05 AM, Erick Erickson (JIRA) <jira@apache.org> wrote:
>
>     [ https://issues.apache.org/jira/browse/LUCENE-4362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13449766#comment-13449766
]
>
> Erick Erickson commented on LUCENE-4362:
> ----------------------------------------
>
> OK, my test failures apparently related to this patch, I'm getting the same thing after
rolling it all back. I'll post on the dev list.
>
>> ban tab-indented source
>> -----------------------
>>
>>                 Key: LUCENE-4362
>>                 URL: https://issues.apache.org/jira/browse/LUCENE-4362
>>             Project: Lucene - Core
>>          Issue Type: Task
>>            Reporter: Robert Muir
>>            Assignee: Erick Erickson
>>         Attachments: LUCENE-4362_core.patch, LUCENE-4362.patch, LUCENE-4362.patch
>>
>>
>> This makes code really difficult to read and work with.
>> Its easy enough to prevent.
>> {noformat}
>> Index: build.xml
>> ===================================================================
>> --- build.xml (revision 1380979)
>> +++ build.xml (working copy)
>> @@ -77,11 +77,12 @@
>>          <or>
>>            <containsregexp expression="@author\b" casesensitive="yes"/>
>>            <containsregexp expression="\bno(n|)commit\b" casesensitive="no"/>
>> +          <containsregexp expression="\t" casesensitive="no"/>
>>          </or>
>>        </fileset>
>>        <map from="${validate.currDir}${file.separator}" to="* "/>
>>      </pathconvert>
>> -    <fail if="validate.patternsFound">The following files contain @author
tags or nocommits:${line.separator}${validate.patternsFound}</fail>
>> +    <fail if="validate.patternsFound">The following files contain @author
tags, tabs or nocommits:${line.separator}${validate.patternsFound}</fail>
>>    </target>
>> {noformat}
>
> --
> This message is automatically generated by JIRA.
> If you think it was sent incorrectly, please contact your JIRA administrators
> For more information on JIRA, see: http://www.atlassian.com/software/jira
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
> For additional commands, e-mail: dev-help@lucene.apache.org
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message