lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Steven Rowe (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-1560) maxDocBytesToAnalyze should be required arg up front
Date Wed, 19 Sep 2012 18:58:08 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-1560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13458972#comment-13458972
] 

Steven Rowe commented on LUCENE-1560:
-------------------------------------

I think this issue is still valid?

The nabble.com email thread link in the description is broken - here's the markmail.org thread:
[http://markmail.org/thread/2pcdjsurrrqoxuew].

{{maxDocBytesToAnalyze()}} was deprecated as part of LUCENE-1132 in favor of {{maxDocCharsToAnalyze()}},
and then removed with the 3.0 release deprecation removals as part of LUCENE-2022.

There is one commented-out vestige that ought to be renamed or removed (my vote is removal
- this was commented out six years ago):

{code:java}
265: //	  if(lastEndOffset>maxDocBytesToAnalyze)
266: //   {
267: //     break;
268: //   }
{code}

                
> maxDocBytesToAnalyze should be required arg up front
> ----------------------------------------------------
>
>                 Key: LUCENE-1560
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1560
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: modules/highlighter
>    Affects Versions: 2.4.1
>            Reporter: Michael McCandless
>             Fix For: 4.1
>
>
> We recently changed IndexWriter to require you to specify up-front
> MaxFieldLength, on creation, so that you are aware of this dangerous
> "loses stuff" setting.  Too many developers had fallen into the trap
> of "how come my search can't find this document...".
> I think we should do the same with "maxDocBytesToAnalyze" with
> highlighter?
> Spinoff from this thread:
>     http://www.nabble.com/Lucene-Highlighting-and-Dynamic-Summaries-p22385887.html

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message