lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "David Smiley (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (SOLR-3304) Add Solr support for the new Lucene spatial module
Date Tue, 11 Sep 2012 06:48:08 GMT

     [ https://issues.apache.org/jira/browse/SOLR-3304?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

David Smiley updated SOLR-3304:
-------------------------------

    Attachment: SOLR-3304_Solr_fields_for_Lucene_spatial_module.patch

Thanks for finding and fixing that bug Andy. Your fix wasn't quite right though since the
getStrategy() method you refactored synchronized on a parameter (pointless) instead of the
field. I fixed this.

This new patch makes that and various other changes:
* synchronized with the latest source tree (e.g. Spatial4j 0.3)
** This means distances are now degrees based (0-180 for circle radius) not kilometers
* removed ignoreIncompatibleGeometry option (see LUCENE-4173)
* Use the input string as the stored value that is returned.  So if you give "lat,lon" then
that's what you get back, in whatever number of decimal places you chose.
* added prefixGridScanLevel performance tuning option to SpatialRecursivePrefixTreeFieldType
(simply exposed it from the strategy)
* keep distErrPct as a fraction (no change)

It would be nice to have a kilometer unit option but that isn't easily done until Spatial4j's
shape reader gets to be more flexible.  That can wait.

That "needScore" local-param hack (see SOLR-2883) is unfortunate, as Solr can't get a Filter
from a field type.  I'm tempted to change the default to 'false' as leaving it at true' triggers
large RAM requirements and slow-downs for SpatialRecursivePrefixTreeFieldType.  This could
be an opportunity to specify what the score should be, come to think of it.  Instead of needScore="false",
maybe score="none" (default) or score="distance" or score="recipDistance" or something like
that.

The TwoDoubles strategy needs more attention and tests in Lucene spatial, but I don't want
that to hold up this patch.  Shall I remove the adapter or let it get committed but don't
advertise it until it's more worthy?
                
> Add Solr support for the new Lucene spatial module
> --------------------------------------------------
>
>                 Key: SOLR-3304
>                 URL: https://issues.apache.org/jira/browse/SOLR-3304
>             Project: Solr
>          Issue Type: New Feature
>    Affects Versions: 4.0-ALPHA
>            Reporter: Bill Bell
>            Assignee: David Smiley
>              Labels: spatial
>         Attachments: SOLR-3304_Solr_fields_for_Lucene_spatial_module (fieldName in Strategy)
- indexableFields.patch, SOLR-3304_Solr_fields_for_Lucene_spatial_module (fieldName in Strategy).patch,
SOLR-3304_Solr_fields_for_Lucene_spatial_module.patch, SOLR-3304_Solr_fields_for_Lucene_spatial_module.patch,
SOLR-3304_Solr_fields_for_Lucene_spatial_module.patch, SOLR-3304-strategy-getter-fixed.patch
>
>
> Get the Solr spatial module integrated with the lucene spatial module.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message