lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hoss Man (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-3861) regresion of SOLR-2008 - updateHandler should be closed before searcherExecutor
Date Tue, 25 Sep 2012 00:54:07 GMT

    [ https://issues.apache.org/jira/browse/SOLR-3861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13462311#comment-13462311
] 

Hoss Man commented on SOLR-3861:
--------------------------------

comments on the patch:

1) overall it seems correct.

2) probably want to move the ":HACK: normally we rely on updateHandler to do this" down to
a new else clauses on the the if block where  getSolrCoreState().tryCloseDirectory() is called
just for sanity's sake.

3) Maybe i'm missing something, but it's not really clear to me why we need the new tryCloseDirectory
... it seems like it would be more straight forward just to make SolrCore responsible for
creating/decrefing/closing the SolrCoreState before/after creating/closing the UpdateHandler?
 (the three arg UpdateHandler constructor could still ask the previous UpdateHandler for the
solrCoreState, but the default behavior would be to get it from the SolreCore. ) 



                
> regresion of SOLR-2008 - updateHandler should be closed before searcherExecutor
> -------------------------------------------------------------------------------
>
>                 Key: SOLR-3861
>                 URL: https://issues.apache.org/jira/browse/SOLR-3861
>             Project: Solr
>          Issue Type: Bug
>    Affects Versions: 4.0-ALPHA, 4.0-BETA
>            Reporter: Hoss Man
>            Assignee: Mark Miller
>            Priority: Blocker
>             Fix For: 4.1, 5.0
>
>         Attachments: SOLR-3861.patch
>
>
> SOLR-2008 fixed a possible RejectedExecutionException by ensuring that SolrCore closed
the updateHandler before the searcherExecutor.
> [~markrmiller@gmail.com] re-flipped this logic in r1159378, which is annotated as fixing
both SOLR-2654 and SOLR-2654 (dup typo i guess) but it's not clear why - pretty sure this
means that the risk of a Rejected exception is back in 4.0-BETA...
> https://svn.apache.org/viewvc/lucene/dev/trunk/solr/core/src/java/org/apache/solr/core/SolrCore.java?r1=1146905&r2=1159378

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message