lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chris Male (JIRA)" <>
Subject [jira] [Commented] (LUCENE-4419) Test RecursivePrefixTree indexing non-point data
Date Mon, 24 Sep 2012 01:56:07 GMT


Chris Male commented on LUCENE-4419:

bq. I'm all for what you suggest – a test that could be used by multiple strategies

I didn't suggest that.  I suggested a common suite of Shapes.  I don't like the idea of having
a single test for all Strategys since they work in different ways and support different things.

bq. I like randomized tests because it can catch errors that a static test simply didn't test

Theres a difference between randomized tests and randomized Shape generation (again I didn't
suggest we stopped randomized testing).  The world is massive, much of it isn't remotely interesting
or challenging to our spatial implementations.  Just generating arbitrary Shapes somewhere
on the globe seems a total waste of time.  

If we have a standard set of Shapes then we can use randomized testing to handle the permutations
between them, but we shouldn't waste days waiting for tests to hit an interesting Shape.
> Test RecursivePrefixTree indexing non-point data
> ------------------------------------------------
>                 Key: LUCENE-4419
>                 URL:
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: modules/spatial
>            Reporter: David Smiley
> RecursivePrefixTreeFilter was modified in ~July 2011 to support spatial filtering of
non-point indexed shapes.  It seems to work when playing with the capability but it isn't
tested.  It really needs to be as this is a major feature.
> I imagine an approach in which some randomly generated rectangles are indexed and then
a randomly generated rectangle is queried.  The right answer can be calculated brute-force
and then compared with the filter.  In order to deal with shape imprecision, the randomly
generated shapes could be generated to fit a course grid (e.g. round everything to a 1 degree

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see:

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message