lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Steven Rowe (JIRA)" <>
Subject [jira] [Commented] (LUCENE-4384) add top-level 'ant precommit'
Date Fri, 14 Sep 2012 01:01:08 GMT


Steven Rowe commented on LUCENE-4384:

Now that LUCENE-4385 is committed and I've added the {{rat-sources}} exclusions required to
get rat to ignore my IntelliJ {{*.iml}} files, all three ant targets under discussion here
ran successfully for me.

I did hit a snag with {{javadocs-lint}} that I've resolved.  I was getting errors complaining
about permission being denied when creating a process.  

The property named {{python32.exe}} is used by {{javadocs-lint}}.  Under Cygwin, because the
default {{python32.exe}} property value ({{python3.2}}) is the same as a Cygwin symlink (to
{{python3.2m.exe}}), and because native Java (Cygwin doesn't provide Java binaries) doesn't
understand Cygwin symlinks, I had to add {{-Dpython32.exe=python3.2m.exe}} to my {{$ANT_OPTS}}
to get {{ant javadocs-lint}} to work.
> add top-level 'ant precommit'
> -----------------------------
>                 Key: LUCENE-4384
>                 URL:
>             Project: Lucene - Core
>          Issue Type: Task
>          Components: general/build
>            Reporter: Robert Muir
>         Attachments: LUCENE-4384.patch
> We have a lot more checks in the build:
> If we added 'ant precommit' it would make it easier to run all the (reasonably fast)
checks beforehand... and save some typing.
> So I think we can just add precommit which is:
> * check-svn-working-copy (looks for un-added files, wrong eol-style)
> * validate (nocommit/author checks, license headers, 3rd party licenses, forbidden apis)
> * javadocs-lint (javadocs + missing/broken links checks)
> * test

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see:

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message