lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "David Smiley (JIRA)" <j...@apache.org>
Subject [jira] [Created] (LUCENE-4413) Better use of exceptions in spatial
Date Fri, 21 Sep 2012 13:49:07 GMT
David Smiley created LUCENE-4413:
------------------------------------

             Summary: Better use of exceptions in spatial
                 Key: LUCENE-4413
                 URL: https://issues.apache.org/jira/browse/LUCENE-4413
             Project: Lucene - Core
          Issue Type: Improvement
          Components: modules/spatial
            Reporter: David Smiley
            Priority: Minor


Spatial4j's InvalidShapeException is supposed to be for shape strings that won't parse or
invalid coordinates.  TwoDoublesStrategy is using it incorrectly to indicate the strategy
doesn't support the shape.

Perhaps UnsupportedOperationException is more fitting.  I kind of prefer it just slightly
over IllegalArgumentException because I  think of it here as the strategy not supporting that
shape.

The biggest point here is consistency across the strategies.

FYI for context there's also UnsupportedSpatialOperation, an Exception that doesn't follow
the naming convention but I'm ok with that.  Its c'tor mandates its association with an instance
of SpatialOperation.  So if a strategy doesn't support an operation then it's got a special
exception just for that, but not also true for shape?  Seems lopsided to me.  I think my preference
is for this exception to be UnsupportedSpatialArgument that isn't locked to either the shape
or operation.

The attached patch doesn't go as far as UnsupportedSpatialArgument but it at least bring consistent
behavior.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message