lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Uwe Schindler (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-3895) For several reasons, disabling the resolving of external entities within the Solr UpdateRequestHandler for XML would be good.
Date Wed, 26 Sep 2012 22:01:08 GMT

    [ https://issues.apache.org/jira/browse/SOLR-3895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13464223#comment-13464223
] 

Uwe Schindler commented on SOLR-3895:
-------------------------------------

{code}
+<!-- DOCTYPE is used test that external entities are not resolved, but named entities
are -->
{code}

This should be: "DOCTYPE is used to test that named entities are resolved". Or better: revert
the whole XSL...
There is already a test that explicitely tests external entities for XSLs :-) You find the
test and the entity in TestXSLTResponseWriter and related files. So the whole test with adding
entities to the XSL is separately handled, we can undo the XSL change.
                
> For several reasons, disabling the resolving of external entities within the Solr UpdateRequestHandler
for XML would be good.
> -----------------------------------------------------------------------------------------------------------------------------
>
>                 Key: SOLR-3895
>                 URL: https://issues.apache.org/jira/browse/SOLR-3895
>             Project: Solr
>          Issue Type: Improvement
>          Components: update
>    Affects Versions: 3.6.1, 4.0-BETA
>            Reporter: Martin Herfurt
>            Assignee: Uwe Schindler
>            Priority: Minor
>             Fix For: 4.1, 5.0
>
>         Attachments: SOLR-3895.patch, SOLR-3895.patch, SOLR-3895.patch, SOLR-3895.patch
>
>
> The Solr UpdateRequestHandler for XML currently resolves so-called XML External Entities.
Not resolving XML External Entities would - among other things - improve Solr's update performance.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message