lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Muir (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-4430) Lucene Demo module should not ship with servlet-api.jar file
Date Wed, 26 Sep 2012 01:08:09 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-4430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13463427#comment-13463427
] 

Robert Muir commented on LUCENE-4430:
-------------------------------------

{quote}
personally i don't think it makes sense for the smoke checker to scan all the third-party
jars looking for javax.* and java.*, that seems like something we should really only worry
about for the solr/lucene jars – precisely because it's going to make it a pain if/when
we want to add more contribs/plugins that depend on non-standard javax.* libs. but if folks
think the best way to deal with this is scan everything and enumerate the exceptions, so be
it.
{quote}

I would like the check myself. I think these are "special" enough:
* CDDL license (e.g. LUCENE-4431)
* may not make sense for binary distribution (eg this issue: LUCENE-4430)
* shouldnt be packed into certain things like wars (e.g. SOLR-3879)

These are 3 blocker issues that came up out of a release candidate.

I'll happily pay the price of having to add an exception to this smoke tester once in a while
if it fails on this when a new jar gets added (its currently run in jenkins, although only
once a week).

IMO the days of manually examining this type of shit is over. Lets leave it to automation,
and avoid
stuff like this coming up late in the release cycle.

                
> Lucene Demo module should not ship with servlet-api.jar file
> ------------------------------------------------------------
>
>                 Key: LUCENE-4430
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4430
>             Project: Lucene - Core
>          Issue Type: Bug
>          Components: modules/other
>    Affects Versions: 4.0-BETA
>            Reporter: Uwe Schindler
>            Assignee: Uwe Schindler
>            Priority: Blocker
>             Fix For: 4.1, 5.0, 4.0
>
>         Attachments: LUCENE-4430.patch
>
>
> As noted in SOLR-3879, Mike's new check in the smoketester found out that Lucene's binary
release ships with a servlet-api.jar file in the Lucene demo module. This file is an interface-only
file and is provided by the servlet container where you would run the webapp.
> This file should be removed from the binary release (the License is also questionable,
because the "original" Sun License of servlet-api.jar was CDDL, although thats unimportant
because it is an API definition file and not a implementation with actual program code. Shipping
any binary code with servlet-api.jar is as wrong as shipping a Java project with JDK's rt.jar
bundled).
> In general we should (in another issue) restructure our lib folders and differentiate
(using IVY configs) between compile-time dependencies and run-time dependencies. Servlet-api.jar
is a typical example for a pure-compile-time dep.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message