lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Muir (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-4362) ban tab-indented source
Date Wed, 05 Sep 2012 04:49:10 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-4362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13448474#comment-13448474
] 

Robert Muir commented on LUCENE-4362:
-------------------------------------

{noformat}
BUILD FAILED
/home/rmuir/workspace/lucene-trunk/build.xml:85: The following files contain @author tags,
tabs or nocommits:
* lucene/analysis/common/src/java/org/apache/lucene/analysis/br/BrazilianAnalyzer.java
* lucene/analysis/common/src/java/org/apache/lucene/analysis/br/BrazilianStemmer.java
* lucene/analysis/common/src/java/org/apache/lucene/analysis/charfilter/HTMLStripCharFilter.java
* lucene/analysis/common/src/java/org/apache/lucene/analysis/compound/DictionaryCompoundWordTokenFilterFactory.java
* lucene/analysis/common/src/java/org/apache/lucene/analysis/compound/HyphenationCompoundWordTokenFilterFactory.java
* lucene/analysis/common/src/java/org/apache/lucene/analysis/cz/CzechAnalyzer.java
* lucene/analysis/common/src/java/org/apache/lucene/analysis/miscellaneous/CapitalizationFilterFactory.java
* lucene/analysis/common/src/java/org/apache/lucene/analysis/miscellaneous/HyphenatedWordsFilter.java
* lucene/analysis/common/src/java/org/apache/lucene/analysis/miscellaneous/HyphenatedWordsFilterFactory.java
* lucene/analysis/common/src/java/org/apache/lucene/analysis/path/PathHierarchyTokenizerFactory.java
* lucene/analysis/common/src/java/org/apache/lucene/analysis/query/QueryAutoStopWordAnalyzer.java
* lucene/analysis/common/src/java/org/apache/lucene/analysis/shingle/ShingleFilter.java
* lucene/analysis/common/src/java/org/apache/lucene/analysis/standard/ClassicTokenizerImpl.java
* lucene/analysis/common/src/java/org/apache/lucene/analysis/standard/StandardTokenizerImpl.java
* lucene/analysis/common/src/java/org/apache/lucene/analysis/standard/UAX29URLEmailTokenizerImpl.java
* lucene/analysis/common/src/java/org/apache/lucene/analysis/wikipedia/WikipediaTokenizerImpl.java
* lucene/analysis/common/src/java/org/tartarus/snowball/Among.java
* lucene/analysis/common/src/java/org/tartarus/snowball/SnowballProgram.java
* lucene/analysis/common/src/test/org/apache/lucene/analysis/br/TestBrazilianStemmer.java
* lucene/analysis/common/src/test/org/apache/lucene/analysis/core/WordBreakTestUnicode_6_1_0.java
* lucene/analysis/common/src/test/org/apache/lucene/analysis/el/GreekAnalyzerTest.java
* lucene/analysis/common/src/test/org/apache/lucene/analysis/fr/TestFrenchAnalyzer.java
* lucene/analysis/common/src/test/org/apache/lucene/analysis/miscellaneous/TestHyphenatedWordsFilter.java
* lucene/analysis/common/src/test/org/apache/lucene/analysis/nl/TestDutchStemmer.java
* lucene/analysis/common/src/test/org/apache/lucene/analysis/pattern/TestPatternTokenizer.java
* lucene/analysis/common/src/test/org/apache/lucene/analysis/th/TestThaiAnalyzer.java
* lucene/analysis/common/src/test/org/apache/lucene/analysis/util/TestWordlistLoader.java
* lucene/analysis/kuromoji/src/java/org/apache/lucene/analysis/ja/JapaneseTokenizer.java
* lucene/analysis/kuromoji/src/java/org/apache/lucene/analysis/ja/dict/BinaryDictionary.java
* lucene/analysis/kuromoji/src/java/org/apache/lucene/analysis/ja/dict/Dictionary.java
* lucene/analysis/kuromoji/src/java/org/apache/lucene/analysis/ja/dict/UnknownDictionary.java
* lucene/analysis/kuromoji/src/java/org/apache/lucene/analysis/ja/dict/UserDictionary.java
* lucene/analysis/kuromoji/src/java/org/apache/lucene/analysis/ja/util/CSVUtil.java
* lucene/analysis/kuromoji/src/test/org/apache/lucene/analysis/ja/TestJapaneseTokenizer.java
* lucene/analysis/kuromoji/src/test/org/apache/lucene/analysis/ja/dict/UserDictionaryTest.java
* lucene/analysis/kuromoji/src/tools/java/org/apache/lucene/analysis/ja/util/TokenInfoDictionaryBuilder.java
* lucene/analysis/kuromoji/src/tools/java/org/apache/lucene/analysis/ja/util/UnknownDictionaryBuilder.java
* lucene/analysis/phonetic/src/test/org/apache/lucene/analysis/phonetic/TestPhoneticFilterFactory.java
* lucene/analysis/smartcn/src/java/org/apache/lucene/analysis/cn/smart/hhmm/AbstractDictionary.java
* lucene/benchmark/src/java/org/apache/lucene/benchmark/byTask/utils/StreamUtils.java
* lucene/benchmark/src/test/org/apache/lucene/benchmark/byTask/tasks/WriteLineDocTaskTest.java
* lucene/benchmark/src/test/org/apache/lucene/benchmark/byTask/utils/StreamUtilsTest.java
* lucene/core/src/java/org/apache/lucene/codecs/FixedGapTermsIndexReader.java
* lucene/core/src/java/org/apache/lucene/codecs/lucene40/BitVector.java
* lucene/core/src/java/org/apache/lucene/index/CheckIndex.java
* lucene/core/src/java/org/apache/lucene/index/DocumentsWriterFlushControl.java
* lucene/core/src/java/org/apache/lucene/index/IndexFileDeleter.java
* lucene/core/src/java/org/apache/lucene/index/IndexWriter.java
* lucene/core/src/java/org/apache/lucene/index/SegmentInfo.java
* lucene/core/src/java/org/apache/lucene/search/BooleanQuery.java
* lucene/core/src/java/org/apache/lucene/search/FieldCache.java
* lucene/core/src/java/org/apache/lucene/search/FieldCacheImpl.java
* lucene/core/src/java/org/apache/lucene/search/FilteredDocIdSetIterator.java
* lucene/core/src/java/org/apache/lucene/search/MultiPhraseQuery.java
* lucene/core/src/java/org/apache/lucene/search/PhrasePositions.java
* lucene/core/src/java/org/apache/lucene/search/PhraseQuery.java
* lucene/core/src/java/org/apache/lucene/search/payloads/MinPayloadFunction.java
* lucene/core/src/java/org/apache/lucene/search/payloads/PayloadFunction.java
* lucene/core/src/java/org/apache/lucene/search/payloads/PayloadNearQuery.java
* lucene/core/src/java/org/apache/lucene/search/spans/NearSpansOrdered.java
* lucene/core/src/java/org/apache/lucene/search/spans/NearSpansUnordered.java
* lucene/core/src/java/org/apache/lucene/search/spans/SpanNearQuery.java
* lucene/core/src/java/org/apache/lucene/search/spans/SpanPositionCheckQuery.java
* lucene/core/src/java/org/apache/lucene/search/spans/Spans.java
* lucene/core/src/java/org/apache/lucene/store/BufferedIndexInput.java
* lucene/core/src/java/org/apache/lucene/store/Lock.java
* lucene/core/src/java/org/apache/lucene/util/Constants.java
* lucene/core/src/java/org/apache/lucene/util/PriorityQueue.java
* lucene/core/src/test/org/apache/lucene/index/TestLongPostings.java
* lucene/core/src/test/org/apache/lucene/index/TestParallelReaderEmptyIndex.java
* lucene/core/src/test/org/apache/lucene/index/TestSameTokenSamePosition.java
* lucene/core/src/test/org/apache/lucene/index/TestTransactionRollback.java
* lucene/core/src/test/org/apache/lucene/index/TestTransactions.java
* lucene/core/src/test/org/apache/lucene/search/TestCachingCollector.java
* lucene/core/src/test/org/apache/lucene/search/TestDocIdSet.java
* lucene/core/src/test/org/apache/lucene/search/TestFuzzyQuery.java
* lucene/core/src/test/org/apache/lucene/search/payloads/TestPayloadNearQuery.java
* lucene/core/src/test/org/apache/lucene/search/spans/TestBasics.java
* lucene/core/src/test/org/apache/lucene/store/TestWindowsMMap.java
* lucene/core/src/test/org/apache/lucene/util/TestBitUtil.java
* lucene/core/src/test/org/apache/lucene/util/TestFixedBitSet.java
* lucene/core/src/test/org/apache/lucene/util/TestOpenBitSet.java
* lucene/facet/src/java/org/apache/lucene/facet/taxonomy/directory/DirectoryTaxonomyReader.java
* lucene/highlighter/src/java/org/apache/lucene/search/highlight/DefaultEncoder.java
* lucene/highlighter/src/java/org/apache/lucene/search/highlight/Encoder.java
* lucene/highlighter/src/java/org/apache/lucene/search/highlight/Formatter.java
* lucene/highlighter/src/java/org/apache/lucene/search/highlight/GradientFormatter.java
* lucene/highlighter/src/java/org/apache/lucene/search/highlight/Highlighter.java
* lucene/highlighter/src/java/org/apache/lucene/search/highlight/InvalidTokenOffsetsException.java
* lucene/highlighter/src/java/org/apache/lucene/search/highlight/QueryTermExtractor.java
* lucene/highlighter/src/java/org/apache/lucene/search/highlight/SimpleHTMLEncoder.java
* lucene/highlighter/src/java/org/apache/lucene/search/highlight/SimpleHTMLFormatter.java
* lucene/highlighter/src/java/org/apache/lucene/search/highlight/SpanGradientFormatter.java
* lucene/highlighter/src/java/org/apache/lucene/search/highlight/TextFragment.java
* lucene/highlighter/src/java/org/apache/lucene/search/highlight/WeightedTerm.java
* lucene/queries/src/java/org/apache/lucene/queries/function/valuesource/DualFloatFunction.java
* lucene/queries/src/java/org/apache/lucene/queries/function/valuesource/MultiBoolFunction.java
* lucene/queries/src/java/org/apache/lucene/queries/function/valuesource/ScaleFloatFunction.java
* lucene/queries/src/java/org/apache/lucene/queries/function/valuesource/SimpleBoolFunction.java
* lucene/queries/src/java/org/apache/lucene/queries/function/valuesource/SimpleFloatFunction.java
* lucene/queryparser/src/java/org/apache/lucene/queryparser/classic/FastCharStream.java
* lucene/queryparser/src/java/org/apache/lucene/queryparser/flexible/core/nodes/FieldQueryNode.java
* lucene/queryparser/src/java/org/apache/lucene/queryparser/flexible/standard/parser/FastCharStream.java
* lucene/queryparser/src/java/org/apache/lucene/queryparser/flexible/standard/parser/StandardSyntaxParser.java
* lucene/queryparser/src/java/org/apache/lucene/queryparser/surround/parser/FastCharStream.java
* lucene/queryparser/src/java/org/apache/lucene/queryparser/surround/query/BasicQueryFactory.java
* lucene/queryparser/src/java/org/apache/lucene/queryparser/surround/query/RewriteQuery.java
* lucene/queryparser/src/java/org/apache/lucene/queryparser/surround/query/SimpleTermRewriteQuery.java
* lucene/queryparser/src/java/org/apache/lucene/queryparser/xml/CoreParser.java
* lucene/queryparser/src/java/org/apache/lucene/queryparser/xml/CorePlusExtensionsParser.java
* lucene/queryparser/src/java/org/apache/lucene/queryparser/xml/DOMUtils.java
* lucene/queryparser/src/java/org/apache/lucene/queryparser/xml/FilterBuilder.java
* lucene/queryparser/src/java/org/apache/lucene/queryparser/xml/ParserException.java
* lucene/queryparser/src/java/org/apache/lucene/queryparser/xml/QueryBuilder.java
* lucene/queryparser/src/java/org/apache/lucene/queryparser/xml/QueryTemplateManager.java
* lucene/queryparser/src/java/org/apache/lucene/queryparser/xml/builders/CachedFilterBuilder.java
* lucene/queryparser/src/java/org/apache/lucene/queryparser/xml/builders/NumericRangeFilterBuilder.java
* lucene/queryparser/src/java/org/apache/lucene/queryparser/xml/builders/SpanQueryBuilder.java
* lucene/queryparser/src/java/org/apache/lucene/queryparser/xml/builders/UserInputQueryBuilder.java
* lucene/queryparser/src/test/org/apache/lucene/queryparser/xml/TestQueryTemplateManager.java
* lucene/sandbox/src/java/org/apache/lucene/sandbox/queries/FuzzyLikeThisQuery.java
* lucene/sandbox/src/test/org/apache/lucene/sandbox/queries/TestSlowFuzzyQuery.java
* lucene/suggest/src/java/org/apache/lucene/search/spell/DirectSpellChecker.java
* lucene/suggest/src/java/org/apache/lucene/search/spell/SpellChecker.java
* lucene/suggest/src/java/org/apache/lucene/search/suggest/tst/TernaryTreeNode.java
* lucene/test-framework/src/java/org/apache/lucene/analysis/MockTokenizer.java
* lucene/test-framework/src/java/org/apache/lucene/util/LuceneTestCase.java
* lucene/test-framework/src/java/org/apache/lucene/util/RunListenerPrintReproduceInfo.java
* solr/contrib/dataimporthandler/src/java/org/apache/solr/handler/dataimport/DIHLogLevels.java
* solr/contrib/dataimporthandler/src/java/org/apache/solr/handler/dataimport/DIHWriter.java
* solr/contrib/dataimporthandler/src/java/org/apache/solr/handler/dataimport/DataImportHandler.java
* solr/contrib/dataimporthandler/src/java/org/apache/solr/handler/dataimport/DataImporter.java
* solr/contrib/dataimporthandler/src/java/org/apache/solr/handler/dataimport/DebugLogger.java
* solr/contrib/dataimporthandler/src/java/org/apache/solr/handler/dataimport/DocBuilder.java
* solr/contrib/dataimporthandler/src/java/org/apache/solr/handler/dataimport/EntityProcessorBase.java
* solr/contrib/dataimporthandler/src/java/org/apache/solr/handler/dataimport/SimplePropertiesWriter.java
* solr/contrib/dataimporthandler/src/java/org/apache/solr/handler/dataimport/SolrWriter.java
* solr/contrib/dataimporthandler/src/test/org/apache/solr/handler/dataimport/AbstractDIHCacheTestCase.java
* solr/contrib/dataimporthandler/src/test/org/apache/solr/handler/dataimport/TestSortedMapBackedCache.java
* solr/contrib/uima/src/test/org/apache/solr/uima/ts/EntityAnnotation_Type.java
* solr/contrib/uima/src/test/org/apache/solr/uima/ts/SentimentAnnotation_Type.java
* solr/contrib/velocity/src/java/org/apache/solr/response/PageTool.java
* solr/core/src/java/org/apache/solr/cloud/CloudDescriptor.java
* solr/core/src/java/org/apache/solr/core/Config.java
* solr/core/src/java/org/apache/solr/core/CoreContainer.java
* solr/core/src/java/org/apache/solr/handler/component/ResponseBuilder.java
* solr/core/src/java/org/apache/solr/handler/component/SpellCheckComponent.java
* solr/core/src/java/org/apache/solr/handler/loader/CSVLoaderBase.java
* solr/core/src/java/org/apache/solr/response/PHPSerializedResponseWriter.java
* solr/core/src/java/org/apache/solr/response/RawResponseWriter.java
* solr/core/src/java/org/apache/solr/response/SolrQueryResponse.java
* solr/core/src/java/org/apache/solr/schema/SchemaField.java
* solr/core/src/java/org/apache/solr/search/QParser.java
* solr/core/src/java/org/apache/solr/search/SolrIndexSearcher.java
* solr/core/src/java/org/apache/solr/spelling/AbstractLuceneSpellChecker.java
* solr/core/src/java/org/apache/solr/spelling/ConjunctionSolrSpellChecker.java
* solr/core/src/java/org/apache/solr/spelling/DirectSolrSpellChecker.java
* solr/core/src/java/org/apache/solr/util/LongPriorityQueue.java
* solr/core/src/test/org/apache/solr/TestDistributedGrouping.java
* solr/core/src/test/org/apache/solr/handler/XmlUpdateRequestHandlerTest.java
* solr/core/src/test/org/apache/solr/handler/XsltUpdateRequestHandlerTest.java
* solr/core/src/test/org/apache/solr/handler/component/DistributedSpellCheckComponentTest.java
* solr/core/src/test/org/apache/solr/handler/component/SpellCheckComponentTest.java
* solr/core/src/test/org/apache/solr/handler/component/StatsComponentTest.java
* solr/core/src/test/org/apache/solr/highlight/DummyHighlighter.java
* solr/core/src/test/org/apache/solr/highlight/HighlighterConfigTest.java
* solr/core/src/test/org/apache/solr/search/SpatialFilterTest.java
* solr/core/src/test/org/apache/solr/search/function/NvlValueSourceParser.java
* solr/core/src/test/org/apache/solr/spelling/DirectSolrSpellCheckerTest.java
* solr/core/src/test/org/apache/solr/spelling/SpellCheckCollatorTest.java
* solr/core/src/test/org/apache/solr/spelling/SpellPossibilityIteratorTest.java
* solr/core/src/test/org/apache/solr/update/UpdateParamsTest.java
* solr/solrj/src/java/org/apache/solr/client/solrj/beans/DocumentObjectBinder.java
* solr/solrj/src/java/org/apache/solr/client/solrj/request/LukeRequest.java
* solr/solrj/src/java/org/apache/solr/client/solrj/response/SpellCheckResponse.java
* solr/solrj/src/java/org/apache/solr/common/cloud/ZkStateReader.java
* solr/solrj/src/java/org/apache/solr/common/util/NamedList.java
* solr/solrj/src/test/org/apache/solr/client/solrj/response/TestSpellCheckResponse.java

Total time: 2 seconds
{noformat}
                
> ban tab-indented source
> -----------------------
>
>                 Key: LUCENE-4362
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4362
>             Project: Lucene - Core
>          Issue Type: Task
>            Reporter: Robert Muir
>         Attachments: LUCENE-4362_core.patch
>
>
> This makes code really difficult to read and work with.
> Its easy enough to prevent.
> {noformat}
> Index: build.xml
> ===================================================================
> --- build.xml	(revision 1380979)
> +++ build.xml	(working copy)
> @@ -77,11 +77,12 @@
>          <or>
>            <containsregexp expression="@author\b" casesensitive="yes"/>
>            <containsregexp expression="\bno(n|)commit\b" casesensitive="no"/>
> +          <containsregexp expression="\t" casesensitive="no"/>
>          </or>
>        </fileset>
>        <map from="${validate.currDir}${file.separator}" to="* "/>
>      </pathconvert>
> -    <fail if="validate.patternsFound">The following files contain @author tags
or nocommits:${line.separator}${validate.patternsFound}</fail>
> +    <fail if="validate.patternsFound">The following files contain @author tags,
tabs or nocommits:${line.separator}${validate.patternsFound}</fail>
>    </target>
> {noformat}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message