lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Muir (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-4435) rethink TestCheckIndex.testLuceneConstantVersion
Date Wed, 26 Sep 2012 12:51:08 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-4435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13463768#comment-13463768
] 

Robert Muir commented on LUCENE-4435:
-------------------------------------

{quote}
against a hard-wired official
version (o.a.l.util.Constants.LUCENE_MAIN_VERSION).
{quote}

This is the REALLY important one we should actually be testing!

I would prefer that instead: in TestBackwardsCompatibility we add a test that reads this version
from the old index,
then makes a current index and uses the comparator to ensure that the new one is greater than
the old index.

This will ensure nobody forgets to bump LUCENE_MAIN_VERSION, which is important because it
allows us to determine
which version of lucene wrote the segment.

                
> rethink TestCheckIndex.testLuceneConstantVersion
> ------------------------------------------------
>
>                 Key: LUCENE-4435
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4435
>             Project: Lucene - Core
>          Issue Type: Bug
>          Components: general/test
>            Reporter: Robert Muir
>
> This test currently checks the "display version" of lucene which is set by the ant build.xml
variable.
> But its been problematic in the past: and I'm sure its annoying for people running from
things like IDEs.
> I think LUCENE-4428 is a more straightforward way of checking that the version is set
correctly, it verifies the actual JAR metadata.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message