lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Steven Rowe (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-4384) add top-level 'ant precommit'
Date Thu, 13 Sep 2012 20:41:07 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-4384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13455253#comment-13455253
] 

Steven Rowe commented on LUCENE-4384:
-------------------------------------

{quote}
I looked at the config and it seems its output directories are in fact lucene/build ?

I think this is a significant risk: if someone with this IDE were to build a release it could
be completely different than what we expect (include extra stuff or missing some stuff), or
even just act strange because bytecode was compiled by something like the ecj compiler unexpectedly?
{quote}

bq. It would definitely be a good idea to put IntelliJ build output somewhere different from
Ant's (similarly to Eclipse and Maven now), I've just never gotten around to it.

See LUCENE-4385
                
> add top-level 'ant precommit'
> -----------------------------
>
>                 Key: LUCENE-4384
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4384
>             Project: Lucene - Core
>          Issue Type: Task
>          Components: general/build
>            Reporter: Robert Muir
>         Attachments: LUCENE-4384.patch
>
>
> We have a lot more checks in the build:
> If we added 'ant precommit' it would make it easier to run all the (reasonably fast)
checks beforehand... and save some typing.
> So I think we can just add precommit which is:
> * check-svn-working-copy (looks for un-added files, wrong eol-style)
> * validate (nocommit/author checks, license headers, 3rd party licenses, forbidden apis)
> * javadocs-lint (javadocs + missing/broken links checks)
> * test

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message