lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "James Dyer (JIRA)" <>
Subject [jira] [Updated] (SOLR-3671) DIH doesn't use its own interface + writerImpl has no information about the request
Date Fri, 14 Sep 2012 15:02:08 GMT


James Dyer updated SOLR-3671:

         Priority: Minor  (was: Major)
    Fix Version/s:     (was: 4.0)

This is a nice-to-have but doesn't need to be rushed into 4.0.  Removing the fix version and
changing to "minor".
> DIH doesn't use its own interface + writerImpl has no information about the request
> -----------------------------------------------------------------------------------
>                 Key: SOLR-3671
>                 URL:
>             Project: Solr
>          Issue Type: Improvement
>          Components: contrib - DataImportHandler
>    Affects Versions: 4.0-ALPHA, 4.0-BETA
>            Reporter: roman
>            Assignee: James Dyer
>            Priority: Minor
>         Attachments: SOLR-3671.patch
> The use case: I would like to extend DIH by providing a new writer, I have tried everything
but can't accomplish it without either a) duplicating whole DIHandler or b) java reflection
tricks. Almost everything inside DIH is private and the mechanism to instantiate a new writer
based on the 'writerImpl' mechanism seems lacking important functionality
> It doesn't give the new class a chance to get information about the request, update processor.
Also, the writer is instantiated twice (when 'writerImpl' is there), which is really unnecessary.
> As a solution, the existing DIHandler.getSolrWriter() should instantiate the appropriate
writer and send it to DocBuilder (it is already doing that for SolrWriter). And DocBuilder
doesn't need to create a second (duplicate) writer

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see:

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message