lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hoss Man (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-4415) need to document/fix/remove build.xml dependencies on javascript
Date Sat, 22 Sep 2012 02:05:07 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-4415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13461003#comment-13461003
] 

Hoss Man commented on LUCENE-4415:
----------------------------------

{quote}OK I guess the ideal situation here would be to add js.jar to this solr module's test-classpath?
Is that enough for the scripting integration to work so the test will run?
{quote}

On a freebsd machine? i have no idea - but either way that really seems like it should be
a separate issue from this one (and shoulnd't be a blocker for 4.0)...

1) it's not related to the ant build, and i doubt you mean you would then have the ant macros
use a classpath based on jars downloaded for the the solr modules test-classpath
2) it doesn't currently prevent the build from working, or tests from passing, on any known
machine.  as i mentioned: those tests already use assume() to skip themselves if you don't
have javascript support: just like other test we already have that skip themselves if your
JVM doesn't support a pre-req.
3) it's not clear to me that it's even a good idea.  doing that could give people who run
the tests the impression that javascript engine support will work for them in solr on their
machine (because the tests will say "PASS" instead of "SKIPPED") but then in a real solr instance
it won't work unless they customize the jvm or the classpath.

...but like i say: seems like we should worry about that in a distinct issue
                
> need to document/fix/remove build.xml dependencies on javascript
> ----------------------------------------------------------------
>
>                 Key: LUCENE-4415
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4415
>             Project: Lucene - Core
>          Issue Type: Bug
>            Reporter: Hoss Man
>            Assignee: Uwe Schindler
>            Priority: Blocker
>             Fix For: 4.0
>
>         Attachments: LUCENE-4415-option2.patch, LUCENE-4415-option2.patch
>
>
> Radim Kolar pointed out on the solr-user mailing list that he was unable to build Solr
on his FreeBSD machine due to the use of {{<script language="javascript"... />}} tags
in the ant build file, and the lack of javascript by default in his Java install.  There was
no clear indication that he should need anything else.
> It seems like prior to releasing 4.0, we should do one of the following:
> 1) find a way to remove the dependency on using javascript in the build.xml files (ie:
our own custom ant target written in java?)
> 2) use ivy to ensure we have the rhino jar in a classpath we pass to {{<script>}}
tag (it appears we already do something similar for pegdown)
> 3) update lucene/BUILD.txt and solr/README.txt to make it clear that the rhino js.jar
is a build requirement (and link to a wiki somewhere that provides tips on how to install
it in ant if your JVM doesn't include it)
> (Assigning to Uwe in hopes that he has some inspiration, i know he's familiar with this
scripting deficiency on FreeBSD)
> https://mail-archives.apache.org/mod_mbox/lucene-solr-user/201209.mbox/%3C505CF59E.4000600%40filez.com%3E

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message