lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Steven Rowe (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-4384) add top-level 'ant precommit'
Date Fri, 14 Sep 2012 00:47:08 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-4384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13455497#comment-13455497
] 

Steven Rowe commented on LUCENE-4384:
-------------------------------------

{quote}
bq. I got rat-sources to shut up by adding */.iml to the rat.excludes definition in lucene/common-build.xml.

Hmm I think i've never hit this because of using eclipse: not having .iml files. Can you commit
this exclusion?
{quote}

bq. Done: r1384502 (trunk), r1384513 (branch_4x)

I also had to add {{\*\*/\*.iml}} to the {{rat.excludes}} definition in {{solr/core/build.xml}}:
r1384608 (trunk) and r1384615 (branch_4x).

                
> add top-level 'ant precommit'
> -----------------------------
>
>                 Key: LUCENE-4384
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4384
>             Project: Lucene - Core
>          Issue Type: Task
>          Components: general/build
>            Reporter: Robert Muir
>         Attachments: LUCENE-4384.patch
>
>
> We have a lot more checks in the build:
> If we added 'ant precommit' it would make it easier to run all the (reasonably fast)
checks beforehand... and save some typing.
> So I think we can just add precommit which is:
> * check-svn-working-copy (looks for un-added files, wrong eol-style)
> * validate (nocommit/author checks, license headers, 3rd party licenses, forbidden apis)
> * javadocs-lint (javadocs + missing/broken links checks)
> * test

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message