lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Amit Nithian (JIRA)" <j...@apache.org>
Subject [jira] [Closed] (SOLR-712) Support for relative path XML Entity Includes
Date Tue, 11 Sep 2012 06:48:07 GMT

     [ https://issues.apache.org/jira/browse/SOLR-712?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Amit Nithian closed SOLR-712.
-----------------------------

       Resolution: Fixed
    Fix Version/s:     (was: 4.1)
                   4.0

This looks to have been resolved by the various XML parser changes. Awesome!
                
> Support for relative path XML Entity Includes
> ---------------------------------------------
>
>                 Key: SOLR-712
>                 URL: https://issues.apache.org/jira/browse/SOLR-712
>             Project: Solr
>          Issue Type: Improvement
>    Affects Versions: 1.2, 1.3
>            Reporter: Amit Nithian
>            Priority: Minor
>             Fix For: 4.0
>
>         Attachments: XMLEntityInclude.tgz
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> This patch modifies the Config.java and IndexSchema.java to support XML entity includes
of relative paths. When parsing an InputStream not providing a SystemID (i.e. base path for
example) to the DOM parser will basically force all entity includes to be relative to the
base project directory rather than the directory hosting the document. This patch simply passes
in the configuration directory as the systemID thus making the entity includes relative to
the home of solrconfig.xml and schema.xml. 
> The IndexSchema.java was modified to ensure objects do NOT process the xml:base attribute.
Newer Xerces-J parsers allow for the removal of this attribute in the DOM (by setting the
appropriate feature); however, the DOM parser used by Java 5 doesn't support this feature.
> For example:
> Without the entity include, if my Solr app was running on C:\solr, then any entity includes
would have to be relative to C:\solr regardless of solrconfig.xml and schema.xml. This patch
allows for includes relative to the conf directory of solr.home (i.e. ../../my_base_schema.xml)
would be located two directories above "conf".
> Please submit improvements or comments on this patch. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message