lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chris Male (JIRA)" <>
Subject [jira] [Commented] (LUCENE-4375) Spatial BBoxIntersects and BBoxWithin are used incorrectly
Date Wed, 12 Sep 2012 03:31:08 GMT


Chris Male commented on LUCENE-4375:

In the future, once we remove much of the restrictions on the SpatialStrategy interface, we
could have implementations of PTS that was limited to Points and supported isWithin.  Till
then, I don't think we should include hacks just to support isWithin for Points.  Lets leave
the API nice and we'll make improvements when we can.
> Spatial BBoxIntersects and BBoxWithin are used incorrectly
> ----------------------------------------------------------
>                 Key: LUCENE-4375
>                 URL:
>             Project: Lucene - Core
>          Issue Type: Bug
>            Reporter: David Smiley
>            Assignee: David Smiley
>             Fix For: 4.0
>         Attachments: LUCENE-4375_Fix_use_of_BBoxWithin_BBoxIntersects_and_IsWithin.patch
> SpatialOperation has two special BBoxIntersects and BBoxWithin choices.  I assumed these
where the bounding boxes of the query shape but [~ryantxu] informed me these are supposed
to be for the *indexed shape*.  There is no strategy in Lucene spatial that could use this
but there is one externally -- JtsGeoStrategy.  Javadocs should be added to clarify, and various
places like SpatialArgs.getShape() should be fixed to not use it incorrectly.
> This does remove a feature from the Solr adapters side; the test there will need to change.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see:

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message