lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Muir (JIRA)" <j...@apache.org>
Subject [jira] [Created] (LUCENE-4380) fix simplefs/niofshierarchy
Date Wed, 12 Sep 2012 14:17:07 GMT
Robert Muir created LUCENE-4380:
-----------------------------------

             Summary: fix simplefs/niofshierarchy
                 Key: LUCENE-4380
                 URL: https://issues.apache.org/jira/browse/LUCENE-4380
             Project: Lucene - Core
          Issue Type: Task
            Reporter: Robert Muir
         Attachments: LUCENE-4380.patch

spinoff from LUCENE-4371:

Currently NIOFSDirectory.NIOFSIndexInput extends SimpleFSDirectory.SimpleFSIndexInput, but
this isn't an is-a relationship at all.

Additionally SimpleFSDirectory has a funky Descriptor class that extends RandomAccessFile
that is useless:
{noformat}
    /**
     * Extension of RandomAccessFile that tracks if the file is 
     * open.
     */
...
      // remember if the file is open, so that we don't try to close it
      // more than once
{noformat}

RandomAccessFile is closeable, this is not necessary and I don't think we should be subclassing
it.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message