lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "David Smiley (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (LUCENE-4375) Spatial BBoxIntersects and BBoxWithin are used incorrectly
Date Wed, 12 Sep 2012 03:21:07 GMT

     [ https://issues.apache.org/jira/browse/LUCENE-4375?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

David Smiley updated LUCENE-4375:
---------------------------------

    Attachment: LUCENE-4375_Fix_use_of_BBoxWithin_BBoxIntersects_and_IsWithin.patch

This patch addresses the BBoxWithin and BBoxIntersects misuse.

I also noticed problematic use of IsWithin by PrefixTreeStrategy.  A PrefixTreeStrategy can
index all shapes, not just points, so it can't be sure if IsWithin is supported.  It seemed
simple enough to remove support for it but in order to make the tests pass I had to change
various test references to "IsWithin" and make it Intersects, like renaming cities-IsWithin-BBox.txt
to use Intersects in its name and content.  Perhaps it wouldn't be too much of a hack for
this strategy to have a pointOnly boolean which has the side-effect of making IsWithin synonymous
with Intersects?
                
> Spatial BBoxIntersects and BBoxWithin are used incorrectly
> ----------------------------------------------------------
>
>                 Key: LUCENE-4375
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4375
>             Project: Lucene - Core
>          Issue Type: Bug
>            Reporter: David Smiley
>            Assignee: David Smiley
>             Fix For: 4.0
>
>         Attachments: LUCENE-4375_Fix_use_of_BBoxWithin_BBoxIntersects_and_IsWithin.patch
>
>
> SpatialOperation has two special BBoxIntersects and BBoxWithin choices.  I assumed these
where the bounding boxes of the query shape but [~ryantxu] informed me these are supposed
to be for the *indexed shape*.  There is no strategy in Lucene spatial that could use this
but there is one externally -- JtsGeoStrategy.  Javadocs should be added to clarify, and various
places like SpatialArgs.getShape() should be fixed to not use it incorrectly.
> This does remove a feature from the Solr adapters side; the test there will need to change.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message