lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Muir (JIRA)" <>
Subject [jira] [Commented] (LUCENE-4371) consider refactoring slicer to indexinput.slice
Date Mon, 10 Sep 2012 17:55:08 GMT


Robert Muir commented on LUCENE-4371:

Well realistically I'm not sure we have to fix this for 4.0? We could do this one later in
a fairly backwards compatible/compatiblish way:

E.g. a good approach might be to make Directory.createSlicer just call clone/slice.

Another safer alternative might introduce a minor break: by making that deprecation final
and having CFS code just use slice() directly,
listing it in the backwards break section. this would just be a minor break in expert usage.
> consider refactoring slicer to indexinput.slice
> -----------------------------------------------
>                 Key: LUCENE-4371
>                 URL:
>             Project: Lucene - Core
>          Issue Type: Task
>            Reporter: Robert Muir
>         Attachments: LUCENE-4371.patch
> From LUCENE-4364:
> {quote}
> In my opinion, we should maybe check, if we can remove the whole Slicer in all Indexinputs?
Just make the slice(...) method return the current BufferedIndexInput-based one. This could
be another issue, once this is in.
> {quote}

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see:

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message