lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Steven Rowe (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-4384) add top-level 'ant precommit'
Date Thu, 13 Sep 2012 20:05:07 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-4384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13455189#comment-13455189
] 

Steven Rowe commented on LUCENE-4384:
-------------------------------------

I like it.

{{rat-sources}} is complaining about my ({{svn:ignore}}'d) {{*.iml}} IntelliJ IDEA module
configuration files sprinkled throughout the source.

I got {{rat-sources}} to shut up by adding {{\**/*.iml}} to the {{rat.excludes}} definition
in {{lucene/common-build.xml}}.

{{check-forbidden-apis}} fails miserably though:

{noformat}
-check-system-out:
[forbidden-apis] Reading API signatures: C:\svn\lucene\dev\trunk\lucene\tools\forbiddenApis\system-out.txt
[forbidden-apis] Loading classes to check...
[forbidden-apis] Scanning for API signatures and dependencies...
[forbidden-apis] Forbidden field access: java.lang.System#out
[forbidden-apis]   in org.apache.lucene.analysis.icu.GenerateJFlexSupplementaryMacros (GenerateJFlexSupplementaryMacros.java:76)
[forbidden-apis] Forbidden field access: java.lang.System#out
[forbidden-apis]   in org.apache.lucene.analysis.icu.GenerateJFlexSupplementaryMacros (GenerateJFlexSupplementaryMacros.java:77)
[forbidden-apis] Forbidden field access: java.lang.System#out
[forbidden-apis]   in org.apache.lucene.analysis.icu.GenerateJFlexSupplementaryMacros (GenerateJFlexSupplementaryMacros.java:78)
[forbidden-apis] Forbidden field access: java.lang.System#out
[forbidden-apis]   in org.apache.lucene.analysis.icu.GenerateJFlexSupplementaryMacros (GenerateJFlexSupplementaryMacros.java:79)
[forbidden-apis] Forbidden field access: java.lang.System#out
[forbidden-apis]   in org.apache.lucene.analysis.icu.GenerateJFlexSupplementaryMacros (GenerateJFlexSupplementaryMacros.java:80)
[forbidden-apis] Forbidden field access: java.lang.System#out
[forbidden-apis]   in org.apache.lucene.analysis.icu.GenerateJFlexSupplementaryMacros (GenerateJFlexSupplementaryMacros.java:88)
[forbidden-apis] Forbidden field access: java.lang.System#out
[forbidden-apis]   in org.apache.lucene.analysis.icu.GenerateJFlexSupplementaryMacros (GenerateJFlexSupplementaryMacros.java:91)
[forbidden-apis] Forbidden field access: java.lang.System#out
[forbidden-apis]   in org.apache.lucene.analysis.icu.GenerateJFlexSupplementaryMacros (GenerateJFlexSupplementaryMacros.java:108)
[forbidden-apis] Forbidden field access: java.lang.System#out
[forbidden-apis]   in org.apache.lucene.analysis.icu.GenerateJFlexSupplementaryMacros (GenerateJFlexSupplementaryMacros.java:110)
[forbidden-apis] Forbidden field access: java.lang.System#out
[forbidden-apis]   in org.apache.lucene.analysis.icu.GenerateJFlexSupplementaryMacros (GenerateJFlexSupplementaryMacros.java:112)
[forbidden-apis] Forbidden field access: java.lang.System#out
[forbidden-apis]   in org.apache.lucene.analysis.icu.GenerateHTMLStripCharFilterSupplementaryMacros
(GenerateHTMLStripCharFilterSupplementaryMacros.java:62)
[forbidden-apis] Forbidden field access: java.lang.System#out
[forbidden-apis]   in org.apache.lucene.analysis.icu.GenerateHTMLStripCharFilterSupplementaryMacros
(GenerateHTMLStripCharFilterSupplementaryMacros.java:63)
[forbidden-apis] Forbidden field access: java.lang.System#out
[forbidden-apis]   in org.apache.lucene.analysis.icu.GenerateHTMLStripCharFilterSupplementaryMacros
(GenerateHTMLStripCharFilterSupplementaryMacros.java:64)
[forbidden-apis] Forbidden field access: java.lang.System#out
[forbidden-apis]   in org.apache.lucene.analysis.icu.GenerateHTMLStripCharFilterSupplementaryMacros
(GenerateHTMLStripCharFilterSupplementaryMacros.java:65)
[forbidden-apis] Forbidden field access: java.lang.System#out
[forbidden-apis]   in org.apache.lucene.analysis.icu.GenerateHTMLStripCharFilterSupplementaryMacros
(GenerateHTMLStripCharFilterSupplementaryMacros.java:66)
[forbidden-apis] Forbidden field access: java.lang.System#out
[forbidden-apis]   in org.apache.lucene.analysis.icu.GenerateHTMLStripCharFilterSupplementaryMacros
(GenerateHTMLStripCharFilterSupplementaryMacros.java:74)
[forbidden-apis] Forbidden field access: java.lang.System#out
[forbidden-apis]   in org.apache.lucene.analysis.icu.GenerateHTMLStripCharFilterSupplementaryMacros
(GenerateHTMLStripCharFilterSupplementaryMacros.java:77)
[forbidden-apis] Forbidden field access: java.lang.System#out
[forbidden-apis]   in org.apache.lucene.analysis.icu.GenerateHTMLStripCharFilterSupplementaryMacros
(GenerateHTMLStripCharFilterSupplementaryMacros.java:104)
[forbidden-apis] Forbidden field access: java.lang.System#out
[forbidden-apis]   in org.apache.lucene.analysis.icu.GenerateHTMLStripCharFilterSupplementaryMacros
(GenerateHTMLStripCharFilterSupplementaryMacros.java:106)
[forbidden-apis] Forbidden field access: java.lang.System#out
[forbidden-apis]   in org.apache.lucene.analysis.icu.GenerateHTMLStripCharFilterSupplementaryMacros
(GenerateHTMLStripCharFilterSupplementaryMacros.java:108)
[forbidden-apis] Forbidden field access: java.lang.System#out
[forbidden-apis]   in org.egothor.stemmer.DiffIt (DiffIt.java:105)
[forbidden-apis] Forbidden field access: java.lang.System#out
[forbidden-apis]   in org.egothor.stemmer.DiffIt (DiffIt.java:109)
[forbidden-apis] Forbidden field access: java.lang.System#err
[forbidden-apis]   in org.apache.lucene.analysis.icu.GenerateUTR30DataFiles (GenerateUTR30DataFiles.java:87)
[forbidden-apis] Forbidden field access: java.lang.System#err
[forbidden-apis]   in org.apache.lucene.analysis.icu.GenerateUTR30DataFiles (GenerateUTR30DataFiles.java:132)
[forbidden-apis] Forbidden field access: java.lang.System#err
[forbidden-apis]   in org.apache.lucene.analysis.icu.GenerateUTR30DataFiles (GenerateUTR30DataFiles.java:134)
[forbidden-apis] Forbidden field access: java.lang.System#err
[forbidden-apis]   in org.apache.lucene.analysis.icu.GenerateUTR30DataFiles (GenerateUTR30DataFiles.java:155)
[forbidden-apis] Forbidden field access: java.lang.System#err
[forbidden-apis]   in org.apache.lucene.analysis.icu.GenerateUTR30DataFiles (GenerateUTR30DataFiles.java:171)
[forbidden-apis] Forbidden field access: java.lang.System#err
[forbidden-apis]   in org.apache.lucene.analysis.icu.GenerateUTR30DataFiles (GenerateUTR30DataFiles.java:173)
[forbidden-apis] Forbidden field access: java.lang.System#err
[forbidden-apis]   in org.apache.lucene.analysis.icu.GenerateUTR30DataFiles (GenerateUTR30DataFiles.java:174)
[forbidden-apis] Forbidden field access: java.lang.System#err
[forbidden-apis]   in org.apache.lucene.analysis.icu.GenerateUTR30DataFiles (GenerateUTR30DataFiles.java:176)
[forbidden-apis] Forbidden field access: java.lang.System#err
[forbidden-apis]   in org.apache.lucene.analysis.icu.GenerateUTR30DataFiles (GenerateUTR30DataFiles.java:178)
[forbidden-apis] Forbidden field access: java.lang.System#err
[forbidden-apis]   in org.apache.lucene.analysis.icu.GenerateUTR30DataFiles (GenerateUTR30DataFiles.java:220)
[forbidden-apis] Forbidden field access: java.lang.System#err
[forbidden-apis]   in org.apache.lucene.analysis.icu.GenerateUTR30DataFiles (GenerateUTR30DataFiles.java:269)
[forbidden-apis] Forbidden field access: java.lang.System#err
[forbidden-apis]   in org.apache.lucene.analysis.standard.GenerateJflexTLDMacros (GenerateJflexTLDMacros.java:51)
[forbidden-apis] Forbidden field access: java.lang.System#err
[forbidden-apis]   in org.apache.lucene.analysis.standard.GenerateJflexTLDMacros (GenerateJflexTLDMacros.java:52)
[forbidden-apis] Forbidden field access: java.lang.System#err
[forbidden-apis]   in org.apache.lucene.analysis.standard.GenerateJflexTLDMacros (GenerateJflexTLDMacros.java:103)
[forbidden-apis] Forbidden field access: java.lang.System#out
[forbidden-apis]   in org.egothor.stemmer.Compile (Compile.java:125)
[forbidden-apis] Forbidden field access: java.lang.System#out
[forbidden-apis]   in org.egothor.stemmer.Compile (Compile.java:181)
[forbidden-apis] Forbidden field access: java.lang.System#out
[forbidden-apis]   in org.apache.lucene.analysis.ja.util.TokenInfoDictionaryBuilder (TokenInfoDictionaryBuilder.java:84)
[forbidden-apis] Forbidden field access: java.lang.System#out
[forbidden-apis]   in org.apache.lucene.analysis.ja.util.TokenInfoDictionaryBuilder (TokenInfoDictionaryBuilder.java:100)
[forbidden-apis] Forbidden field access: java.lang.System#out
[forbidden-apis]   in org.apache.lucene.analysis.ja.util.TokenInfoDictionaryBuilder (TokenInfoDictionaryBuilder.java:123)
[forbidden-apis] Forbidden field access: java.lang.System#out
[forbidden-apis]   in org.apache.lucene.analysis.ja.util.TokenInfoDictionaryBuilder (TokenInfoDictionaryBuilder.java:132)
[forbidden-apis] Forbidden field access: java.lang.System#out
[forbidden-apis]   in org.apache.lucene.analysis.ja.util.TokenInfoDictionaryBuilder (TokenInfoDictionaryBuilder.java:145)
[forbidden-apis] Forbidden field access: java.lang.System#out
[forbidden-apis]   in org.apache.lucene.analysis.ja.util.TokenInfoDictionaryBuilder (TokenInfoDictionaryBuilder.java:167)
[forbidden-apis] Forbidden field access: java.lang.System#out
[forbidden-apis]   in org.apache.lucene.analysis.ja.util.TokenInfoDictionaryBuilder (TokenInfoDictionaryBuilder.java:169)
[forbidden-apis] Forbidden field access: java.lang.System#out
[forbidden-apis]   in org.apache.lucene.analysis.ja.util.DictionaryBuilder (DictionaryBuilder.java:35)
[forbidden-apis] Forbidden field access: java.lang.System#out
[forbidden-apis]   in org.apache.lucene.analysis.ja.util.DictionaryBuilder (DictionaryBuilder.java:41)
[forbidden-apis] Forbidden field access: java.lang.System#out
[forbidden-apis]   in org.apache.lucene.analysis.ja.util.DictionaryBuilder (DictionaryBuilder.java:43)
[forbidden-apis] Forbidden field access: java.lang.System#out
[forbidden-apis]   in org.apache.lucene.analysis.ja.util.DictionaryBuilder (DictionaryBuilder.java:49)
[forbidden-apis] Forbidden field access: java.lang.System#out
[forbidden-apis]   in org.apache.lucene.analysis.ja.util.DictionaryBuilder (DictionaryBuilder.java:51)
[forbidden-apis] Forbidden field access: java.lang.System#out
[forbidden-apis]   in org.apache.lucene.analysis.ja.util.DictionaryBuilder (DictionaryBuilder.java:55)
[forbidden-apis] Forbidden field access: java.lang.System#err
[forbidden-apis]   in org.apache.lucene.analysis.ja.util.DictionaryBuilder (DictionaryBuilder.java:65)
[forbidden-apis] Forbidden field access: java.lang.System#out
[forbidden-apis]   in org.apache.lucene.analysis.ja.util.DictionaryBuilder (DictionaryBuilder.java:74)
[forbidden-apis] Forbidden field access: java.lang.System#out
[forbidden-apis]   in org.apache.lucene.analysis.ja.util.DictionaryBuilder (DictionaryBuilder.java:75)
[forbidden-apis] Forbidden field access: java.lang.System#out
[forbidden-apis]   in org.apache.lucene.analysis.ja.util.DictionaryBuilder (DictionaryBuilder.java:76)
[forbidden-apis] Forbidden field access: java.lang.System#out
[forbidden-apis]   in org.apache.lucene.analysis.ja.util.DictionaryBuilder (DictionaryBuilder.java:77)
[forbidden-apis] Forbidden field access: java.lang.System#out
[forbidden-apis]   in org.apache.lucene.analysis.ja.util.DictionaryBuilder (DictionaryBuilder.java:78)
[forbidden-apis] Forbidden field access: java.lang.System#out
[forbidden-apis]   in org.apache.lucene.analysis.ja.util.DictionaryBuilder (DictionaryBuilder.java:79)
[forbidden-apis] Forbidden field access: java.lang.System#out
[forbidden-apis]   in org.apache.lucene.analysis.ja.util.DictionaryBuilder (DictionaryBuilder.java:80)
[forbidden-apis] Forbidden field access: java.lang.System#out
[forbidden-apis]   in org.apache.lucene.analysis.ja.util.DictionaryBuilder (DictionaryBuilder.java:81)
[forbidden-apis] Forbidden field access: java.lang.System#err
[forbidden-apis]   in org.apache.lucene.analysis.icu.RBBIRuleCompiler (RBBIRuleCompiler.java:63)
[forbidden-apis] Forbidden field access: java.lang.System#err
[forbidden-apis]   in org.apache.lucene.analysis.icu.RBBIRuleCompiler (RBBIRuleCompiler.java:77)
[forbidden-apis] Forbidden field access: java.lang.System#err
[forbidden-apis]   in org.apache.lucene.analysis.icu.RBBIRuleCompiler (RBBIRuleCompiler.java:83)
[forbidden-apis] Forbidden field access: java.lang.System#err
[forbidden-apis]   in org.apache.lucene.analysis.icu.RBBIRuleCompiler (RBBIRuleCompiler.java:89)
[forbidden-apis] Forbidden field access: java.lang.System#out
[forbidden-apis]   in org.apache.lucene.facet.example.ExampleUtils (ExampleUtils.java:34)
[forbidden-apis] Scanned 3034 (and 227 related) class file(s) for forbidden API invocations
(in 1.55s), 65 error(s).
{noformat}

                
> add top-level 'ant precommit'
> -----------------------------
>
>                 Key: LUCENE-4384
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4384
>             Project: Lucene - Core
>          Issue Type: Task
>          Components: general/build
>            Reporter: Robert Muir
>         Attachments: LUCENE-4384.patch
>
>
> We have a lot more checks in the build:
> If we added 'ant precommit' it would make it easier to run all the (reasonably fast)
checks beforehand... and save some typing.
> So I think we can just add precommit which is:
> * check-svn-working-copy (looks for un-added files, wrong eol-style)
> * validate (nocommit/author checks, license headers, 3rd party licenses, forbidden apis)
> * javadocs-lint (javadocs + missing/broken links checks)
> * test

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message