lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mark Miller (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-3861) regresion of SOLR-2008 - updateHandler should be closed before searcherExecutor
Date Wed, 26 Sep 2012 03:06:07 GMT

    [ https://issues.apache.org/jira/browse/SOLR-3861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13463485#comment-13463485
] 

Mark Miller commented on SOLR-3861:
-----------------------------------

bq. do you mean this issue (RejectException) won't impact system such as lost uncommitted
documents?

I don't believe so. If you have the UpdateLog on, you would recover any lost updates there
- but this rejected execution is after the commit anyway - trying to open the searcher after
the commit.

Also, the UpdateHandler does an explicit commit on shutdown that has nothing to do with auto
commit, and does not rely on needing to open a searcher after it's done.

I think if anything, it's an ugly mark in the logs.

The api changes above will remove the ugly part I think - but as far as I know it's all just
cosmetic.
                
> regresion of SOLR-2008 - updateHandler should be closed before searcherExecutor
> -------------------------------------------------------------------------------
>
>                 Key: SOLR-3861
>                 URL: https://issues.apache.org/jira/browse/SOLR-3861
>             Project: Solr
>          Issue Type: Bug
>    Affects Versions: 4.0-ALPHA, 4.0-BETA
>            Reporter: Hoss Man
>            Assignee: Mark Miller
>            Priority: Blocker
>             Fix For: 4.1, 5.0
>
>         Attachments: SOLR-3861.patch, SOLR-3861.patch, SOLR-3861.patch
>
>
> SOLR-2008 fixed a possible RejectedExecutionException by ensuring that SolrCore closed
the updateHandler before the searcherExecutor.
> [~markrmiller@gmail.com] re-flipped this logic in r1159378, which is annotated as fixing
both SOLR-2654 and SOLR-2654 (dup typo i guess) but it's not clear why - pretty sure this
means that the risk of a Rejected exception is back in 4.0-BETA...
> https://svn.apache.org/viewvc/lucene/dev/trunk/solr/core/src/java/org/apache/solr/core/SolrCore.java?r1=1146905&r2=1159378

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message