lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hoss Man (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (SOLR-3671) DIH doesn't use its own interface + writerImpl has no information about the request
Date Sat, 08 Sep 2012 00:25:07 GMT

     [ https://issues.apache.org/jira/browse/SOLR-3671?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Hoss Man updated SOLR-3671:
---------------------------


removing fixVersion=4.0 since there is no evidence that anyone is currently working on this
issue.  (this can certainly be revisited if volunteers step forward)

also assigning to [~jdyer] for patch review.
                
> DIH doesn't use its own interface + writerImpl has no information about the request
> -----------------------------------------------------------------------------------
>
>                 Key: SOLR-3671
>                 URL: https://issues.apache.org/jira/browse/SOLR-3671
>             Project: Solr
>          Issue Type: Improvement
>          Components: contrib - DataImportHandler
>    Affects Versions: 4.0-ALPHA, 4.0-BETA
>            Reporter: roman
>             Fix For: 4.0
>
>         Attachments: SOLR-3671.patch
>
>
> The use case: I would like to extend DIH by providing a new writer, I have tried everything
but can't accomplish it without either a) duplicating whole DIHandler or b) java reflection
tricks. Almost everything inside DIH is private and the mechanism to instantiate a new writer
based on the 'writerImpl' mechanism seems lacking important functionality
> It doesn't give the new class a chance to get information about the request, update processor.
Also, the writer is instantiated twice (when 'writerImpl' is there), which is really unnecessary.
> As a solution, the existing DIHandler.getSolrWriter() should instantiate the appropriate
writer and send it to DocBuilder (it is already doing that for SolrWriter). And DocBuilder
doesn't need to create a second (duplicate) writer

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message