lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hoss Man (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-4415) need to document/fix/remove build.xml dependencies on javascript
Date Sat, 22 Sep 2012 01:27:07 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-4415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13460990#comment-13460990
] 

Hoss Man commented on LUCENE-4415:
----------------------------------

{quote}
and what is the test doing?
is it just testing an arbitrary scripting language to show some scripting integration works?
or is there actual solr code that depends upon this functionality?
{quote}

Both? ... i'm confused by the two options in your question -- Solr has functionality that
lets users define scripts to control. we have tests for this functionality that use javascript
scripts to prove that the fnctionality works (ie: that the script affects the behavior)

Yes we want the tests to run, but if Bob doesn't have support for that scriptengine in his
JVM, there is no other way to re-write the test so that Bob could test it, and Bob couldn't
use that functionality in a real Solr instance anyway.

bq. I'm not sure about this. What about other Java implementations other than Oracle/Sun?
Are they guaranteed to ship with a javascript engine? I really like the ivy idea from this
perspective.

I have all the same questions. I think Uwe said somewhere/sometime that "the spec" required
javascript be provided, hence FreeBSD was broken so he added the jar to jenkins -- but he
may have retracted that comment at a later date (i certainly never found anything to back
it up)


                
> need to document/fix/remove build.xml dependencies on javascript
> ----------------------------------------------------------------
>
>                 Key: LUCENE-4415
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4415
>             Project: Lucene - Core
>          Issue Type: Bug
>            Reporter: Hoss Man
>            Assignee: Uwe Schindler
>            Priority: Blocker
>             Fix For: 4.0
>
>         Attachments: LUCENE-4415-option2.patch
>
>
> Radim Kolar pointed out on the solr-user mailing list that he was unable to build Solr
on his FreeBSD machine due to the use of {{<script language="javascript"... />}} tags
in the ant build file, and the lack of javascript by default in his Java install.  There was
no clear indication that he should need anything else.
> It seems like prior to releasing 4.0, we should do one of the following:
> 1) find a way to remove the dependency on using javascript in the build.xml files (ie:
our own custom ant target written in java?)
> 2) use ivy to ensure we have the rhino jar in a classpath we pass to {{<script>}}
tag (it appears we already do something similar for pegdown)
> 3) update lucene/BUILD.txt and solr/README.txt to make it clear that the rhino js.jar
is a build requirement (and link to a wiki somewhere that provides tips on how to install
it in ant if your JVM doesn't include it)
> (Assigning to Uwe in hopes that he has some inspiration, i know he's familiar with this
scripting deficiency on FreeBSD)
> https://mail-archives.apache.org/mod_mbox/lucene-solr-user/201209.mbox/%3C505CF59E.4000600%40filez.com%3E

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message