lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hoss Man (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (SOLR-3895) For several reasons, disabling the resolving of external entities within the Solr UpdateRequestHandler for XML would be good.
Date Wed, 26 Sep 2012 20:17:07 GMT

     [ https://issues.apache.org/jira/browse/SOLR-3895?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Hoss Man updated SOLR-3895:
---------------------------

    Attachment: SOLR-3895.patch

bq. If a user requests this feature, we can enable in a later issue. But then also xinclude
should be enabled. Any other opinions?

Nope, like i said: we can worry about the detials of making it configurable if/when anyone
asks for it.

bq.  I can extend the patch to also take care of DIH (SOLR-3614)

i figured maybe we could - but we can also worry about it in that issue after this one gets
commited, whatever you think is easier.

bq.  We should add the same one for XSLReqHandler (because it uses other parser).

good call -- i updated the patch to test that named entities still work in XSL transformed
docs & stylesheets, and they do.  But this lead me to discover that SYSTEM entities in
the xsl docs (aparently) aren't being ignored, so with the patch attached (trying to refer
to a bogs file fro mthe XSL) you get a stylesheet compilation error -- so i think maybe there
is still a code path missing the use of your new EmptyEntityResolver?  (either that or i've
just got a silly bug in the stylesheet that isn't obvious to me)
                
> For several reasons, disabling the resolving of external entities within the Solr UpdateRequestHandler
for XML would be good.
> -----------------------------------------------------------------------------------------------------------------------------
>
>                 Key: SOLR-3895
>                 URL: https://issues.apache.org/jira/browse/SOLR-3895
>             Project: Solr
>          Issue Type: Improvement
>          Components: update
>    Affects Versions: 3.6.1, 4.0-BETA
>            Reporter: Martin Herfurt
>            Assignee: Uwe Schindler
>            Priority: Minor
>             Fix For: 4.1, 5.0
>
>         Attachments: SOLR-3895.patch, SOLR-3895.patch, SOLR-3895.patch
>
>
> The Solr UpdateRequestHandler for XML currently resolves so-called XML External Entities.
Not resolving XML External Entities would - among other things - improve Solr's update performance.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message