lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Muir (JIRA)" <>
Subject [jira] [Updated] (LUCENE-4425) Unclear documentation of StoredFieldVisitor.binaryValue
Date Tue, 25 Sep 2012 18:02:08 GMT


Robert Muir updated LUCENE-4425:

    Attachment: LUCENE-4425.patch

here's a patch (not tested) just to see what it would look like.

SolrIndexSearcher was ignoring offset and length too, if we dont fix this issue, we should
at least fix that.
> Unclear documentation of StoredFieldVisitor.binaryValue
> -------------------------------------------------------
>                 Key: LUCENE-4425
>                 URL:
>             Project: Lucene - Core
>          Issue Type: Bug
>    Affects Versions: 4.0
>            Reporter: Adrien Grand
>            Priority: Minor
>             Fix For: 4.1, 5.0
>         Attachments: LUCENE-4425.patch
> When reading the binary value of a stored field, a StoredFieldsReader calls StoredFieldVisitor.binaryValue(arr,
offset, length).
> Documentation currently doesn't state whether the byte[] can be reused outside of the
scope of {{StoredFieldVisitor.binaryValue}} but {{DocumentStoredFieldVisitor}} assumes (as
of r1389812) that it can.
> So {{DocumentStoredFieldVisitor}} would break with a custom {{StoredFieldsFormat}} that
would call {{StoredFieldVisitor.binaryValue}} with a slice of a reusable buffer.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see:

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message