lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yonik Seeley (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-3830) Rename LFUCache to FastLFUCache
Date Wed, 12 Sep 2012 20:00:08 GMT

    [ https://issues.apache.org/jira/browse/SOLR-3830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13454299#comment-13454299
] 

Yonik Seeley commented on SOLR-3830:
------------------------------------

I have a higher bar for renaming things in config files and APIs.
Solr has a large user base with tons of people that know what things do, and we often overlook
the downside of destroying collective knowledge by renaming things that are only a slight
improvement.

I personally think Lucene has gone rename-crazy and wouldn't do many of those if it were up
to me...
                
> Rename LFUCache to FastLFUCache
> -------------------------------
>
>                 Key: SOLR-3830
>                 URL: https://issues.apache.org/jira/browse/SOLR-3830
>             Project: Solr
>          Issue Type: Bug
>    Affects Versions: 4.0-BETA
>            Reporter: Adrien Grand
>            Priority: Minor
>
> I find it a little disturbing that LFUCache shares most of its behavior (not strictly
bounded size, good at concurrent reads, slow at writes unless eviction is performed in a separate
thread) with FastLRUCache while it sounds like it is the LFU equivalent of LRUCache (strictly
bounded size, synchronized reads, fast writes) so I'd like to rename it to FastLFUCache.
> Maybe we should also rename these Fast*Cache to Concurrent*Cache so that people don't
think that they are better than their non Fast alternatives in every way.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message